Introduce additional Mockito Refaster rules (#777)

PicnicSupermarket · Oct 9, 2023 · c48db52 · c48db52
1 parent 629cb57
commit c48db52
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 0 deletions.
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MockitoRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MockitoRules.java
@@ -5,10 +5,12 @@
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 
+import com.google.errorprone.refaster.Refaster;
 import com.google.errorprone.refaster.annotation.AfterTemplate;
 import com.google.errorprone.refaster.annotation.BeforeTemplate;
 import com.google.errorprone.refaster.annotation.UseImportPolicy;
 import org.mockito.Mockito;
+import org.mockito.invocation.InvocationOnMock;
 import org.mockito.verification.VerificationMode;
 import tech.picnic.errorprone.refaster.annotation.OnlineDocumentation;
 
@@ -50,4 +52,30 @@ T after(T mock) {
       return verify(mock);
     }
   }
+
+  static final class InvocationOnMockGetArguments {
+    @BeforeTemplate
+    Object before(InvocationOnMock invocation, int i) {
+      return invocation.getArguments()[i];
+    }
+
+    @AfterTemplate
+    Object after(InvocationOnMock invocation, int i) {
+      return invocation.getArgument(i);
+    }
+  }
+
+  static final class InvocationOnMockGetArgumentsWithTypeParameter<T> {
+    @BeforeTemplate
+    @SuppressWarnings("unchecked")
+    T before(InvocationOnMock invocation, int i) {
+      return Refaster.anyOf(
+          invocation.getArgument(i, Refaster.<T>clazz()), (T) invocation.getArgument(i));
+    }
+
+    @AfterTemplate
+    T after(InvocationOnMock invocation, int i) {
+      return invocation.<T>getArgument(i);
+    }
+  }
 }
diff --git a/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/MockitoRulesTestInput.java b/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/MockitoRulesTestInput.java
@@ -5,6 +5,7 @@
 import static org.mockito.Mockito.verify;
 
 import com.google.common.collect.ImmutableSet;
+import org.mockito.invocation.InvocationOnMock;
 import org.mockito.verification.VerificationMode;
 import tech.picnic.errorprone.refaster.test.RefasterRuleCollectionTestCase;
 
@@ -21,4 +22,14 @@ VerificationMode testNever() {
   Object testVerifyOnce() {
     return verify(mock(Object.class), times(1));
   }
+
+  Object testInvocationOnMockGetArguments() {
+    return ((InvocationOnMock) null).getArguments()[0];
+  }
+
+  ImmutableSet<Number> testInvocationOnMockGetArgumentsWithTypeParameter() {
+    return ImmutableSet.of(
+        ((InvocationOnMock) null).getArgument(0, Integer.class),
+        (Double) ((InvocationOnMock) null).getArgument(1));
+  }
 }
diff --git a/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/MockitoRulesTestOutput.java b/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/MockitoRulesTestOutput.java
@@ -6,6 +6,7 @@
 import static org.mockito.Mockito.verify;
 
 import com.google.common.collect.ImmutableSet;
+import org.mockito.invocation.InvocationOnMock;
 import org.mockito.verification.VerificationMode;
 import tech.picnic.errorprone.refaster.test.RefasterRuleCollectionTestCase;
 
@@ -22,4 +23,14 @@ VerificationMode testNever() {
   Object testVerifyOnce() {
     return verify(mock(Object.class));
   }
+
+  Object testInvocationOnMockGetArguments() {
+    return ((InvocationOnMock) null).getArgument(0);
+  }
+
+  ImmutableSet<Number> testInvocationOnMockGetArgumentsWithTypeParameter() {
+    return ImmutableSet.of(
+        ((InvocationOnMock) null).<Integer>getArgument(0),
+        ((InvocationOnMock) null).<Double>getArgument(1));
+  }
 }