Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore #7

Merged
merged 9 commits into from
Dec 26, 2020
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# General Java development.
.attach_pid*
.classpath
.DS_Store
.factorypath
.idea
.project
.settings
target
*.iml
*.swp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Newline at end of file missing :)

4 changes: 2 additions & 2 deletions error-prone-contrib/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ The following is a list of checks we'd like to see implemented:
`expr.switchIfEmpty(Single.error(...))`, so that an application-specific
exception is thrown instead of `NoSuchElementException`.
- An RxJava-specific check which flags use of `#assertValueSet` without
`#assertValueCount`, as the former method doesn't do what one may intuitivily
`#assertValueCount`, as the former method doesn't do what one may intuitively
rickie marked this conversation as resolved.
Show resolved Hide resolved
expect it to do. See ReactiveX/RxJava#6151.

### Refaster extension ideas
Expand All @@ -262,7 +262,7 @@ Refaster's expressiveness:
rewriting `optional1.map(Optional::of).orElse(optional2)` to `optional1.or(()
-> optional2)` is not behavior preserving if evaluation of `optional2` has
side-effects.
- Similarly, ceratin refactoring operations are only valid if one of the
- Similarly, certain refactoring operations are only valid if one of the
matches expressions is not `@Nullable`. It'd be nice to be able to express
this.
- Generalize `@Placeholder` support such that rules can reference e.g. "any
Expand Down