Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore #7

Merged
merged 9 commits into from
Dec 26, 2020
Merged

Add .gitignore #7

merged 9 commits into from
Dec 26, 2020

Conversation

rickie
Copy link
Member

@rickie rickie commented Dec 23, 2020

This could be of use :)

@rickie rickie requested a review from Stephan202 December 23, 2020 10:05
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR 🎉 . For open source code (which this repo will become!) we have a "curated" .gitignore; see e.g. this one. I think we should use the same one here. (Note that we ignore all IDEA and Eclipse config.)

error-prone-contrib/README.md Show resolved Hide resolved
@rickie
Copy link
Member Author

rickie commented Dec 24, 2020

@Stephan202 thanks! I changed it 😄

@rickie rickie requested a review from Stephan202 December 24, 2020 14:42
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit; will merge :)

.gitignore Outdated
.settings
target
*.iml
*.swp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Newline at end of file missing :)

@Stephan202 Stephan202 merged commit cfd88df into master Dec 26, 2020
@Stephan202 Stephan202 deleted the rossendrijver/take_a_look branch December 26, 2020 21:51
@Stephan202 Stephan202 added this to the 0.1.0 milestone Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants