-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce IsRefasterAsVarargs
matcher for use by Refaster templates
#623
Introduce IsRefasterAsVarargs
matcher for use by Refaster templates
#623
Conversation
Looks good. All 2 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small commit and tweaked the suggested commit message. Thanks @mlrprananta!
Looks good. All 2 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
fdd8bb8
to
d36b0af
Compare
Looks good. All 2 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you picked this up @mlrprananta 🚀 !
public final class IsRefasterAsVarargs implements Matcher<ExpressionTree> { | ||
private static final long serialVersionUID = 1L; | ||
private static final Matcher<ExpressionTree> DELEGATE = | ||
staticMethod().onClass(Refaster.class.getName()).namedAnyOf("asVarargs"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When passing only one, we can use #named
😄.
staticMethod().onClass(Refaster.class.getName()).namedAnyOf("asVarargs"); | |
staticMethod().onClass(Refaster.class.getName()).named("asVarargs"); |
" return Refaster.asVarargs(\"o\");", | ||
" }", | ||
"", | ||
" private static String[] asVarArgs(String s) {", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one test case as we sometimes add this variant as well :).
Looks good. All 2 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Added a commit. @rickie feel free to merge once built. |
Looks good. All 2 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Kudos, SonarCloud Quality Gate passed! |
IsRefasterAsVarargs
matcherIsRefasterAsVarargs
matcher for use by Refaster templates
A follow up for the XXX of
StreamOfArray
encountered in #619