Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce StreamsConcat Refaster rule #619

Merged
merged 4 commits into from
May 14, 2023
Merged

Introduce StreamsConcat Refaster rule #619

merged 4 commits into from
May 14, 2023

Conversation

mlrprananta
Copy link
Contributor

@mlrprananta mlrprananta commented May 9, 2023 •
edited by Stephan202
Loading

❗ This PR is on top of #623. ❗

Small one that came up recently 🙃

Suggested commit message:

Introduce `StreamsConcat` Refaster rule (#619)

@github-actions
Copy link

github-actions bot commented May 9, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@mlrprananta mlrprananta requested review from rickie and Stephan202 May 9, 2023 10:50
@mlrprananta mlrprananta changed the title Introduce StreamConcat Refaster rule Introduce Stream(s)Concat Refaster rules May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@mlrprananta mlrprananta force-pushed the mlrprananta/stream-concat branch from 03a9e44 to a98c446 Compare May 9, 2023 13:13
Stephan202
Stephan202 reviewed May 9, 2023
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look :)

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/StreamRules.java Outdated Show resolved Hide resolved
error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/StreamRules.java Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 9, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@mlrprananta mlrprananta changed the title Introduce Stream(s)Concat Refaster rules Introduce StreamsConcat Refaster rule May 9, 2023
@mlrprananta mlrprananta requested a review from Stephan202 May 9, 2023 15:01
@mlrprananta mlrprananta mentioned this pull request May 10, 2023
Merged
@Stephan202 Stephan202 added this to the 0.11.0 milestone May 11, 2023
@Stephan202 Stephan202 force-pushed the mlrprananta/stream-concat branch from f2fae56 to 78b0417 Compare May 11, 2023 07:17
Stephan202
Stephan202 approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added a commit. Nice!

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/StreamRules.java Outdated Show resolved Hide resolved
error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/StreamRules.java Outdated Show resolved Hide resolved
@Stephan202 Stephan202 changed the base branch from master to mlrprananta/is-refaster-as-varargs-matcher May 11, 2023 07:17
@github-actions
Copy link

Looks good. All 2 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.refaster.matchers.IsRefasterAsVarargs 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie
rickie approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@rickie rickie force-pushed the mlrprananta/is-refaster-as-varargs-matcher branch from fdd8bb8 to d36b0af Compare May 14, 2023 09:24
Base automatically changed from mlrprananta/is-refaster-as-varargs-matcher to master May 14, 2023 14:33
@Stephan202 Stephan202 force-pushed the mlrprananta/stream-concat branch from 78b0417 to c937a5a Compare May 14, 2023 14:37
@Stephan202
Copy link
Member

Rebased; PR now targets the main branch. Will merge once built.

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Stephan202 Stephan202 merged commit 137ec4c into master May 14, 2023
@Stephan202 Stephan202 deleted the mlrprananta/stream-concat branch May 14, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
new feature
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mlrprananta @Stephan202 @rickie