Apply assorted test cleanup #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. No mutations were possible for these changes. |
Stephan202
commented
Apr 2, 2023
Comment on lines
-13
to
-14
| private final CompilationTestHelper compilationTestHelper = | ||
| CompilationTestHelper.newInstance(RedundantStringConversion.class, getClass()); |
There was a problem hiding this comment.
I think that initially we decided against this, but it is more consistent this way (and it may help simplify the generalizations we're discussing in #494).
Comment on lines
-21
to
-22
| private final CompilationTestHelper compilationTestHelper = | ||
| CompilationTestHelper.newInstance(TestChecker.class, getClass()); |
There was a problem hiding this comment.
There's also a BugCheckerRefactoringTestHelper field in SourceCodeTest, but that's part of #561.
oxkitsune
approved these changes
Apr 13, 2023
rickie
approved these changes
Apr 13, 2023
Summary of changes: - Inline more `CompilationTestHelper` fields. - Move inner class to the bottom of the outer class. - Improve test parameter name.
rickie
force-pushed
the
sschroevers/assorted-test-improvements
branch
from
221f1d3 to
6498ced
Compare
|
Rebased, will merge once 🟢. |
|
Looks good. No mutations were possible for these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message: