Introduce SourceCode#unwrapMethodInvocation utility method
#561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
commented
Apr 2, 2023
Comment on lines
+94
to
+96
| if (sourceCode == null || startPosition == Position.NOPOS || endPosition == Position.NOPOS) { | ||
| return unwrapMethodInvocationDroppingWhitespaceAndComments(tree, state); | ||
| } |
There was a problem hiding this comment.
Here and below: not sure how to test the "source code absent" case, so Pitest will complain about those.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
This was referenced Apr 2, 2023
oxkitsune
approved these changes
Apr 6, 2023
rickie
force-pushed
the
sschroevers/introduce-unwrap-method-invocation-utility
branch
from
c731b57 to
5ae92ab
Compare
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
rickie
deleted the
sschroevers/introduce-unwrap-method-invocation-utility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message:
I'll rebase #560 on top of this PR to use the new method. Another upcoming PR will also use it.