Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing JDK 20-ea build for now #419

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Disable failing JDK 20-ea build for now #419

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58dc760
Disable failing JDK 20-ea build for now
Stephan202 Dec 17, 2022
86c2f44
s/reenable/re-enable/
rickie Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ jobs:
jdk: 17.0.4
distribution: temurin
experimental: false
- os: ubuntu-22.04
jdk: 20-ea
distribution: zulu
experimental: true
# XXX: Reenable this build after upgrading to Error Prone 2.17.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on some googling I think "re-enable" is a lot more common to use than "reenable". WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion 🙃

Copy link
Member

@Badbond Badbond Dec 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can circumvent this oddity by using Reactivate instead, as suggested here. 😄

#- os: ubuntu-22.04
# jdk: 20-ea
# distribution: zulu
# experimental: true
runs-on: ${{ matrix.os }}
continue-on-error: ${{ matrix.experimental }}
steps:
Expand Down