Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing JDK 20-ea build for now #419

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Disable failing JDK 20-ea build for now #419

merged 2 commits into from
Dec 19, 2022

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Dec 17, 2022 •
edited by Badbond
Loading

See the analysis in #418 for context.

Suggested commit message:

Disable failing JDK 20-ea build for now (#419)

The build fails due to
openjdk/jdk20@2cb64a75578ccc15a1dfc8c2843aa11d05ca8aa7; the upcoming
Error Prone release includes a workaround for this:
google/error-prone@df033f03cb55c3f26221660ac5ea49bbaeeab289.

@Stephan202
Disable failing JDK 20-ea build for now
58dc760 
The build fails due to
openjdk/jdk20@2cb64a7; the upcoming
Error Prone release includes a fix for this:
google/error-prone@df033f0.
@Stephan202 Stephan202 added this to the 0.7.0 milestone Dec 17, 2022
@Stephan202 Stephan202 requested a review from rickie December 17, 2022 17:43
@Stephan202 Stephan202 mentioned this pull request Dec 17, 2022
Merged
1 task
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie
rickie approved these changes Dec 19, 2022
View reviewed changes
.github/workflows/build.yaml Outdated
jdk: 20-ea
distribution: zulu
experimental: true
# XXX: Reenable this build after upgrading to Error Prone 2.17.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on some googling I think "re-enable" is a lot more common to use than "reenable". WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion 🙃

Copy link
Member

@Badbond Badbond Dec 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can circumvent this oddity by using Reactivate instead, as suggested here. 😄

@Badbond Badbond self-requested a review December 19, 2022 08:12
Badbond
Badbond reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@Badbond Badbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe s/fix/workaround in the suggested commit message in line with the wording of the commit in error prone?

.github/workflows/build.yaml Outdated
jdk: 20-ea
distribution: zulu
experimental: true
# XXX: Reenable this build after upgrading to Error Prone 2.17.
Copy link
Member

@Badbond Badbond Dec 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can circumvent this oddity by using Reactivate instead, as suggested here. 😄

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Badbond
Badbond approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@Badbond Badbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe s/fix/workaround in the suggested commit message in line with the wording of the commit in error prone?

Changed it. Tweaks LGTM. Approving assuming build passes ✔️

@rickie
Copy link
Member

rickie commented Dec 19, 2022

The enable terminology is used more often I would say, so went with the hyphen option :).

@rickie rickie merged commit fd2946a into master Dec 19, 2022
@rickie rickie deleted the sschroevers/disable-jdk-20-ea-build branch December 19, 2022 08:37
@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@Badbond Badbond Badbond approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @Badbond