Introduce MapIsEmpty Refaster rule
#339
Conversation
error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MapRules.java
Outdated
Show resolved
Hide resolved
rickie
force-pushed
the
mlrprananta/PSM-1547
branch
from
b6732fa to
ff9415d
Compare
rickie
force-pushed
the
sschroevers/refaster-map-improvements
branch
from
0b38be5 to
02397eb
Compare
rickie
force-pushed
the
mlrprananta/PSM-1547
branch
from
ff9415d to
0647b3e
Compare
There was a problem hiding this comment.
Added a commit.
Suggested commit message:
Prefer `Map#isEmpty()` over `Map#{keySet,values,entrySet}.isEmpty()` (#339)
(Not sure how to chain method calls with the #...)
Alternative would be:
Introduce `MapIsEmpty` Refaster rule (#339)
One last thing to consider, we could sort the keySet, values and entrySet lexicographically but I think this order also makes sense 🤔.
| @@ -44,4 +44,15 @@ Stream<String> testMapKeyStream() { | |||
| Stream<Integer> testMapValueStream() { | |||
| return ImmutableMap.of("foo", 1).entrySet().stream().map(Map.Entry::getValue); | |||
| } | |||
|
|
|||
| Stream<boolean> testMapIsEmpty() { | |||
There was a problem hiding this comment.
This wasn't flagged because of a tiny line of code missing in the base PR 😬. Will drop this method :).
There was a problem hiding this comment.
Thanks, overlooked that
|
Yeah I was thinking of ordering it lexicographically, but I wanted to stick with the order Stephan already proposed in the other rule |
There was a problem hiding this comment.
W.r.t. ordering: it seems we often order by some fuzzy "frequency" metric. 🤷
Added one commit; don't ask me to exactly explain this ordering; also just following some existing fuzzy logic 😬. (Eventually we'll auto-sort this stuff.)
I think Introduce `MapIsEmpty` Refaster rule (#339) matches what we've done before 👍
mlrprananta
force-pushed
the
mlrprananta/PSM-1547
branch
from
e05e367 to
973446e
Compare
|
Rebased |
rickie
changed the title
map.keySet().isEmpty() to map.isEmpty()MapIsEmpty Refaster rule
Adds an additional refaster Map rule that builts on #337
Suggested commit message: