Apply suggestion

PicnicSupermarket · Nov 8, 2022 · 0647b3e · 0647b3e
1 parent a870c6f
commit 0647b3e
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MapRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MapRules.java
@@ -110,7 +110,7 @@ Stream<V> after(Map<K, V> map) {
   static final class MapIsEmpty<K, V> {
     @BeforeTemplate
     boolean before(Map<K, V> map) {
-      return map.keySet().isEmpty();
+      return Refaster.anyOf(map.keySet(), map.values(), map.entrySet()).isEmpty();
     }
 
     @AfterTemplate

diff --git a/...ne-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/MapRulesTestInput.java b/...ne-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/MapRulesTestInput.java
@@ -48,4 +48,11 @@ Stream<Integer> testMapValueStream() {
   Stream<boolean> testMapIsEmpty() {
     return ImmutableMap.of("foo", 1).entrySet().isEmpty();
   }
+
+  ImmutableSet<Boolean> testMapIsEmpty() {
+    return ImmutableSet.of(
+        ImmutableMap.of("foo", 1).keySet().isEmpty(),
+        ImmutableMap.of("bar", 2).values().isEmpty(),
+        ImmutableMap.of("baz", 3).entrySet().isEmpty());
+  }
 }
diff --git a/...e-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/MapRulesTestOutput.java b/...e-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/MapRulesTestOutput.java
@@ -46,7 +46,10 @@ Stream<Integer> testMapValueStream() {
     return ImmutableMap.of("foo", 1).values().stream();
   }
 
-  Stream<boolean> testMapIsEmpty() {
-    return ImmutableMap.of("foo", 1).isEmpty();
+  ImmutableSet<Boolean> testMapIsEmpty() {
+    return ImmutableSet.of(
+        ImmutableMap.of("foo", 1).isEmpty(),
+        ImmutableMap.of("bar", 2).isEmpty(),
+        ImmutableMap.of("baz", 3).isEmpty());
   }
 }