Introduce ArraysAsList Refaster rule
#1275
Conversation
|
Looks good. No mutations were possible for these changes. |
mohamedsamehsalah
force-pushed
the
mohamedsamehsalah/arrays-as-list
branch
from
42321e0 to
2c2d0df
Compare
|
Looks good. No mutations were possible for these changes. |
Stephan202
changed the title
ArraysAsList refaster ruleArraysAsList Refaster rule
There was a problem hiding this comment.
Added a commit and tweaked the suggested commit message. Tnx @mohamedsamehsalah!
| @AfterTemplate | ||
| List<T> after(T[] array) { | ||
| return Arrays.asList(array); | ||
| } |
There was a problem hiding this comment.
This expression doesn't relate to streams, so it shouldn't be in this class.
| static final class ArraysAsList<T> { | ||
| @BeforeTemplate | ||
| List<T> before(@NotMatches(IsRefasterAsVarargs.class) T[] array) { | ||
| return Arrays.stream(array).toList(); |
There was a problem hiding this comment.
Let's add an XXX to track that we're losing unmodifiability.
(We could also target ImmutableList#copyOf. For now I'll just make a note about this.)
| @@ -86,6 +87,10 @@ Stream<String> testStreamOfArray() { | |||
| return Stream.of(new String[] {"foo", "bar"}); | |||
| } | |||
|
|
|||
| List<String> testArraysAsList() { | |||
| return Arrays.stream(new String[] {"foo", "bar"}).toList(); | |||
There was a problem hiding this comment.
Smaller 😄
| return Arrays.stream(new String[] {"foo", "bar"}).toList(); | |
| return Arrays.stream(new String[0]).toList(); |
|
Looks good. No mutations were possible for these changes. |
|
Suggested commit message