Introduce ArraysAsList refaster rule

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/StreamRules.java

@@ -38,6 +38,7 @@
 import java.util.Comparator;
 import java.util.DoubleSummaryStatistics;
 import java.util.IntSummaryStatistics;
+import java.util.List;
 import java.util.LongSummaryStatistics;
 import java.util.Map;
 import java.util.Objects;
@@ -122,6 +123,21 @@ Stream<T> after(T[] array) {
     }
   }
 
+  /**
+   * Prefer {@link Arrays#asList(Object[])} over {@link Stream#toList()} as the former is clearer.
+   */
+  static final class ArraysAsList<T> {
+    @BeforeTemplate
+    List<T> before(@NotMatches(IsRefasterAsVarargs.class) T[] array) {
+      return Refaster.anyOf(Arrays.stream(array).toList(), Stream.of(array).toList());
+    }
+
+    @AfterTemplate
+    List<T> after(T[] array) {
+      return Arrays.asList(array);
+    }
+  }
+
   /** Don't unnecessarily call {@link Streams#concat(Stream...)}. */
   static final class ConcatOneStream<T> {
     @BeforeTemplate

error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/StreamRulesTestInput.java

@@ -27,6 +27,7 @@
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Streams;
+import java.util.Arrays;
 import java.util.DoubleSummaryStatistics;
 import java.util.IntSummaryStatistics;
 import java.util.List;
@@ -86,6 +87,12 @@ Stream<String> testStreamOfArray() {
     return Stream.of(new String[] {"foo", "bar"});
   }
 
+  ImmutableSet<List<String>> testArraysAsList() {
+    return ImmutableSet.of(
+        Arrays.stream(new String[] {"foo", "bar"}).toList(),
+        Stream.of(new String[] {"foo", "bar"}).toList());
+  }
+
   Stream<Integer> testConcatOneStream() {
     return Streams.concat(Stream.of(1));
   }

error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/StreamRulesTestOutput.java

@@ -87,6 +87,11 @@ Stream<String> testStreamOfArray() {
     return Arrays.stream(new String[] {"foo", "bar"});
   }
 
+  ImmutableSet<List<String>> testArraysAsList() {
+    return ImmutableSet.of(
+        Arrays.asList(new String[] {"foo", "bar"}), Arrays.asList(new String[] {"foo", "bar"}));
+  }
+
   Stream<Integer> testConcatOneStream() {
     return Stream.of(1);
   }