Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude error-prone-{experimental,guidelines} checks from integration tests #1060

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Exclude error-prone-{experimental,guidelines} checks from integration tests #1060

merged 4 commits into from
Mar 4, 2024

Conversation

rickie
Copy link
Member

@rickie rickie commented Mar 1, 2024

No description provided.

@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Mar 1, 2024
@rickie rickie added this to the 0.16.0 milestone Mar 1, 2024
@rickie rickie requested review from Stephan202 and oxkitsune March 1, 2024 10:48
@rickie rickie force-pushed the rossendrijver/fix_checkstyle_with_new_setup branch from 7dab604 to f4c3e30 Compare March 1, 2024 10:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

oxkitsune
oxkitsune previously requested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@oxkitsune oxkitsune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The {experimental,guidelines} doesn't expand properly in the find syntax

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie requested a review from oxkitsune March 1, 2024 12:41
@rickie
Copy link
Member Author

rickie commented Mar 1, 2024

/integration-test

Stephan202
Stephan202 approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit. Suggested commit message:

Exclude `error-prone-{experimental,guidelines}` checks from integration tests (#1060)

integration-tests/checkstyle.sh
Comment on lines -64 to -65
# XXX: Drop the `ErrorProneRuntimeClasspath` exclusion once that check resides
# in a separate Maven module.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below: this exclusion is still present 🙃

integration-tests/checkstyle.sh Outdated
error_prone_patch_flags="${error_prone_shared_flags} -XepPatchLocation:IN_PLACE -XepPatchChecks:$(
find "${error_prone_support_root}" -path "*/META-INF/services/com.google.errorprone.bugpatterns.BugChecker" -print0 \
find "${error_prone_support_root}" -path "*/META-INF/services/com.google.errorprone.bugpatterns.BugChecker" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also wrap this path to the next line.

integration-tests/checkstyle.sh Outdated
Comment on lines 66 to 67
-not -path "*/error-prone-guidelines/*" \
-not -path "*/error-prone-experimental/*" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-not -path "*/error-prone-guidelines/*" \
-not -path "*/error-prone-experimental/*" \
-not -path "*/error-prone-experimental/*" \
-not -path "*/error-prone-guidelines/*" \

Sorting ;)

@Stephan202 Stephan202 changed the title Exclude error-prone-{experimental,guidelines} modules from integration tests Exclude error-prone-{experimental,guidelines} checks from integration tests Mar 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member

/integration-test

@rickie rickie requested a review from benhalasi March 2, 2024 17:48
@rickie rickie mentioned this pull request Mar 4, 2024
Merged
benhalasi
benhalasi approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@benhalasi benhalasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mac, it works like a charm ✅

@rickie rickie force-pushed the rossendrijver/fix_checkstyle_with_new_setup branch from c05c467 to e51c317 Compare March 4, 2024 19:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rickie rickie dismissed oxkitsune’s stale review March 4, 2024 19:47

Addressed the requested changes!

@rickie rickie merged commit 398d162 into master Mar 4, 2024
15 checks passed
@rickie rickie deleted the rossendrijver/fix_checkstyle_with_new_setup branch March 4, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalasi benhalasi benhalasi approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

@oxkitsune oxkitsune Awaiting requested review from oxkitsune

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rickie @Stephan202 @oxkitsune @benhalasi