Skip to content

Commit

Permalink
Exclude error-prone-{experimental,guidelines} checks from integrati…
Browse files Browse the repository at this point in the history
…on tests (#1060)
  • Loading branch information
rickie authored Mar 4, 2024
1 parent 110ac01 commit 398d162
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions integration-tests/checkstyle.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,22 +61,24 @@ format_goal='com.spotify.fmt:fmt-maven-plugin:2.21.1:format'

error_prone_shared_flags='-XepExcludedPaths:(\Q${project.basedir}${file.separator}src${file.separator}\E(it|test|xdocs-examples)\Q${file.separator}resources\E|\Q${project.build.directory}${file.separator}\E).*'

# XXX: Drop the `ErrorProneRuntimeClasspath` exclusion once that check resides
# in a separate Maven module.
error_prone_patch_flags="${error_prone_shared_flags} -XepPatchLocation:IN_PLACE -XepPatchChecks:$(
find "${error_prone_support_root}" -path "*/META-INF/services/com.google.errorprone.bugpatterns.BugChecker" -print0 \
find "${error_prone_support_root}" \
-path "*/META-INF/services/com.google.errorprone.bugpatterns.BugChecker" \
-not -path "*/error-prone-experimental/*" \
-not -path "*/error-prone-guidelines/*" \
-print0 \
| xargs -0 "${grep_command}" -hoP '[^.]+$' \
| "${grep_command}" -v ErrorProneRuntimeClasspath \
| paste -s -d ',' -
)"

# XXX: Drop the `ErrorProneRuntimeClasspath` exclusion once that check resides
# in a separate Maven module.
error_prone_validation_flags="${error_prone_shared_flags} -XepDisableAllChecks $(
find "${error_prone_support_root}" -path "*/META-INF/services/com.google.errorprone.bugpatterns.BugChecker" -print0 \
find "${error_prone_support_root}" \
-path "*/META-INF/services/com.google.errorprone.bugpatterns.BugChecker" \
-not -path "*/error-prone-experimental/*" \
-not -path "*/error-prone-guidelines/*" \
-print0 \
| xargs -0 "${grep_command}" -hoP '[^.]+$' \
| "${sed_command}" -r 's,(.*),-Xep:\1:WARN,' \
| "${grep_command}" -v ErrorProneRuntimeClasspath \
| paste -s -d ' ' -
)"

Expand Down

0 comments on commit 398d162

Please sign in to comment.