-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Basic ROS2 Support #1
Conversation
hello, you may refer https://github.com/RRL-ALeRT/ros_kortex_vision just in case also I can create a pull request if you feel like it |
This is excellent, thank you @skpawar1305! I will pickup your changes too and merge them here. We are testing extensively on a new gen3 with a built-in wrist camera. Once we're confident I think it would be good to get a ros2 branch merged to the upstream on a new branch. I think it will be good for more users to have access with the updated https://github.com/Kinovarobotics/ros2_kortex drivers. Thanks! |
Created an issue in the upstream: Kinovarobotics#19 to figure out what we should do with this, but for now I think we have enough functionality to call this a baseline for ros2 support. More features to come. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anticipatory approval since I'm leaving for vacation today
hello, I've also ported the calibration tool roughly from https://github.com/Kinovarobotics/ros_kortex_vision/tree/feature/calibration-program/cv_calibration, and it works good
|
Yes! That's very good to hear. Please go ahead and open a PR, we can continue moving forward on ros2 development for kinova vision tools in a common location here until we get buy in from Kinova themselves. |
This PR adds ROS2 support to the
kinova_vision
repo, replicating functionality available in the ROS1 implementation.I have tried to keep the node implementation close to the original source, though we should look into additional param configuration like rate limiting publishing, using param gen, and consolidating initialization and configuration. I also haven't generated rviz configuration just yet.
This has been tested in ROS2 humble.
The README has been updated to provide instructions for compiling and launching.
Thanks to @skpawar1305 for his work in the other fork.
Streaming point cloud:
Corresponding RGB image: