Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Resizing Transform #32

Merged
merged 3 commits into from
Feb 17, 2020
Merged

Resizing Transform #32

merged 3 commits into from
Feb 17, 2020

Conversation

justusschock
Copy link
Member

Short Description

Please give a short summary of the main points of this PR

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the RisingTeam
and Reviewer workflows, the only purpose of those is to have a compact view of
the steps)

If there are any questions regarding code style or other conventions check out our
summary.

  • Implementation
  • Docstrings & Typing
  • Check __all__ sections and __init__
  • Unittests (look at the line coverage of your tests, the goal is 100%!)
  • Update notebooks & documentation if necessary
  • Pass all tests
  • Add the checksum of the last implementation commit to the Changelog

RisingTeam

RisingTeam workflow
  • Add pull request to project (optionally delete corresponding project note)
  • Assign correct label (if you don't have permission to do this, someone will do it for you.
    Please make sure to communicate the current status of the pr.)
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, NotebookTests, Documentation)
  • Does the implementation follow rising design conventions?
  • Are the tests useful? (!!!) Are additional tests needed?
    Can you think of critical points which should be covered in an additional test?
  • Optional: Check coverage locally / Check tests locally if GPU is necessary to execute

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #32 into master will decrease coverage by 0.14%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   98.96%   98.81%   -0.15%     
==========================================
  Files          34       34              
  Lines        1252     1266      +14     
==========================================
+ Hits         1239     1251      +12     
- Misses         13       15       +2
Flag Coverage Δ
#unittests 98.81% <86.66%> (-0.15%) ⬇️
Impacted Files Coverage Δ
rising/transforms/affine.py 97.43% <86.66%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1c8ba...9499751. Read the comment docs.

@justusschock justusschock mentioned this pull request Feb 17, 2020
14 tasks
@mibaumgartner mibaumgartner merged commit a160a05 into master Feb 17, 2020
@justusschock justusschock deleted the resizing branch February 17, 2020 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants