You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds additional Affine Transformations. It mainly includes Transformations around the image center and a resizing trafo.
PR Checklist
PR Implementer
This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the RisingTeam
and Reviewer workflows, the only purpose of those is to have a compact view of
the steps)
If there are any questions regarding code style or other conventions check out our summary.
Implementation
Docstrings & Typing
Check __all__ sections and __init__
Unittests (look at the line coverage of your tests, the goal is 100%!)
Update notebooks & documentation if necessary
Pass all tests
Add the checksum of the last implementation commit to the Changelog
RisingTeam
RisingTeam workflow
Add pull request to project (optionally delete corresponding project note)
Assign correct label (if you don't have permission to do this, someone will do it for you.
Please make sure to communicate the current status of the pr.)
Does this PR close an Issue? (add closes #IssueNumber at the bottom if
not already in description)
Reviewer
Reviewer workflow
Do all tests pass? (Unittests, NotebookTests, Documentation)
Does the implementation follow rising design conventions?
Are the tests useful? (!!!) Are additional tests needed?
Can you think of critical points which should be covered in an additional test?
Optional: Check coverage locally / Check tests locally if GPU is necessary to execute
I would like to propose a different naming convention: the default behaviour should be the rotation around the image center (consistent to other frameworks) and the current rotation (from the master branch) should be renamed to something differently (e.g. RotationOrigin)
We need to undo my commit, rename the transforms, rename OriginMixin to something like CenterMixin and check the tests again
Not sure if we really need the origin transforms though .. but we could keep them if you want
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
This PR adds additional Affine Transformations. It mainly includes Transformations around the image center and a resizing trafo.
PR Checklist
PR Implementer
This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the
RisingTeam
and
Reviewer
workflows, the only purpose of those is to have a compact view ofthe steps)
If there are any questions regarding code style or other conventions check out our
summary.
__all__
sections and__init__
RisingTeam
RisingTeam workflow
Please make sure to communicate the current status of the pr.)
closes #IssueNumber
at the bottom ifnot already in description)
Reviewer
Reviewer workflow
rising
design conventions?Can you think of critical points which should be covered in an additional test?