Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat remove non-OCR PDF #41

Merged
merged 8 commits into from
Sep 24, 2024
Merged

Feat remove non-OCR PDF #41

merged 8 commits into from
Sep 24, 2024

Conversation

PhilippMundhenk
Copy link
Owner

@PhilippMundhenk PhilippMundhenk commented Sep 22, 2024

Gives option to remove original scans after OCR (see #28).

Todo:

  • check if OCR actually succeed before removing file.
  • test

@PhilippMundhenk PhilippMundhenk changed the title Feat remove non ocrpdf Feat remove non OCR PDF Sep 22, 2024
@PhilippMundhenk PhilippMundhenk changed the title Feat remove non OCR PDF Feat remove non-OCR PDF Sep 22, 2024
added removal on non-OCR file
remove original after OCR
added description of REMOVE_ORIGINAL_AFTER_OCR
handled setting values to false
handled setting values to false
@PhilippMundhenk PhilippMundhenk marked this pull request as ready for review September 23, 2024 18:38
Copy link
Collaborator

@vgarcia007 vgarcia007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, in my opinion.

@vgarcia007 vgarcia007 merged commit 9c6d931 into master Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants