Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Capture] add eval_jaxpr method to DefaultQubit #6594

Merged
merged 46 commits into from
Nov 20, 2024
Merged

[Capture] add eval_jaxpr method to DefaultQubit #6594

merged 46 commits into from
Nov 20, 2024

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Nov 18, 2024

Context:

Follows on from #6328 . This integrates the new class with DefaultQubit.

Description of the Change:

Implements DefaultQubit.eval_jaxpr with the DefaultQubitInterpreter class.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-78504]

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (c9af833) to head (e9beec7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #6594    +/-   ##
========================================
  Coverage   99.45%   99.45%            
========================================
  Files         450      451     +1     
  Lines       42088    42198   +110     
========================================
+ Hits        41857    41967   +110     
  Misses        231      231            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

tests/devices/default_qubit/test_default_qubit_plxpr.py Outdated Show resolved Hide resolved
Base automatically changed from default-qubit-interpreter to master November 20, 2024 17:45
@albi3ro albi3ro enabled auto-merge (squash) November 20, 2024 18:01
@albi3ro albi3ro merged commit cffb61f into master Nov 20, 2024
46 checks passed
@albi3ro albi3ro deleted the dq-eval-jaxpr branch November 20, 2024 18:19
astralcai pushed a commit that referenced this pull request Nov 20, 2024
**Context:**

Follows on from #6328 . This integrates the new class with
`DefaultQubit`.

**Description of the Change:**

Implements `DefaultQubit.eval_jaxpr` with the `DefaultQubitInterpreter`
class.

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**

[sc-78504]

---------

Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: Pietropaolo Frisoni <[email protected]>
albi3ro added a commit to PennyLaneAI/pennylane-lightning that referenced this pull request Dec 3, 2024
**Context:**

Now that we are decently good at capturing workflows into jaxpr, we want
to start natively executing jaxpr.

We recently merged such a feature for `DefaultQubit`
(PennyLaneAI/pennylane#6594), and now want to
add it to `lightning.qubit` as well.

**Description of the Change:**

Implements `LightningQubit.eval_jaxpr` via a `LightningInterpreter`
class.

**Benefits:**

Execution of captured jaxpr code.

**Possible Drawbacks:**

**Related GitHub Issues:**

[sc-72591]

---------

Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants