-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Capture] add eval_jaxpr
method to DefaultQubit
#6594
Conversation
…AI/pennylane into plxpr-interpreter-base
Co-authored-by: David Wierichs <[email protected]> Co-authored-by: Pietropaolo Frisoni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6594 +/- ##
========================================
Coverage 99.45% 99.45%
========================================
Files 450 451 +1
Lines 42088 42198 +110
========================================
+ Hits 41857 41967 +110
Misses 231 231 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Pietropaolo Frisoni <[email protected]>
**Context:** Follows on from #6328 . This integrates the new class with `DefaultQubit`. **Description of the Change:** Implements `DefaultQubit.eval_jaxpr` with the `DefaultQubitInterpreter` class. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-78504] --------- Co-authored-by: David Wierichs <[email protected]> Co-authored-by: Pietropaolo Frisoni <[email protected]>
**Context:** Now that we are decently good at capturing workflows into jaxpr, we want to start natively executing jaxpr. We recently merged such a feature for `DefaultQubit` (PennyLaneAI/pennylane#6594), and now want to add it to `lightning.qubit` as well. **Description of the Change:** Implements `LightningQubit.eval_jaxpr` via a `LightningInterpreter` class. **Benefits:** Execution of captured jaxpr code. **Possible Drawbacks:** **Related GitHub Issues:** [sc-72591] --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Ali Asadi <[email protected]>
Context:
Follows on from #6328 . This integrates the new class with
DefaultQubit
.Description of the Change:
Implements
DefaultQubit.eval_jaxpr
with theDefaultQubitInterpreter
class.Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-78504]