Implement eval_jaxpr method for lightning.qubit #1002

albi3ro · 2024-11-20T21:38:56Z

Context:

Now that we are decently good at capturing workflows into jaxpr, we want to start natively executing jaxpr.

We recently merged such a feature for DefaultQubit (PennyLaneAI/pennylane#6594), and now want to add it to lightning.qubit as well.

Description of the Change:

Implements LightningQubit.eval_jaxpr via a LightningInterpreter class.

Benefits:

Execution of captured jaxpr code.

Possible Drawbacks:

Related GitHub Issues:

[sc-72591]

.github/CHANGELOG.md

pennylane_lightning/lightning_qubit/lightning_interpreter.py

codecov · 2024-11-21T18:27:07Z

Codecov Report

Attention: Patch coverage is 7.50000% with 74 lines in your changes missing coverage. Please review.

Project coverage is 91.80%. Comparing base (3cdd7e4) to head (360cf5e).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pennylane_lightning/core/lightning_interpreter.py	0.00%	71 Missing ⚠️
pennylane_lightning/core/lightning_newAPI_base.py	62.50%	3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3cdd7e4) and HEAD (360cf5e). Click for more details.

HEAD has 12 uploads less than BASE

Flag BASE (3cdd7e4) HEAD (360cf5e)

20 8

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
- Coverage   97.13%   91.80%   -5.33%     
==========================================
  Files         228      105     -123     
  Lines       36786    16496   -20290     
==========================================
- Hits        35731    15144   -20587     
- Misses       1055     1352     +297

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…I/pennylane-lightning into lightning-interpreter

mudit2812

Looks good @albi3ro . I left a couple of non-blocking comments. I didn't notice qnode present anywhere. Is that deliberate?

pennylane_lightning/core/_version.py

pennylane_lightning/lightning_qubit/lightning_interpreter.py

tests/lightning_qubit/test_eval_jaxpr.py

AmintorDusko

Thank you, @albi3ro. We have some failing Cis and format problems. Could you please check this? I left some suggestions for that.

pennylane_lightning/lightning_qubit/lightning_interpreter.py

tests/lightning_qubit/test_eval_jaxpr.py

albi3ro · 2024-11-22T21:51:19Z

Looks good @albi3ro . I left a couple of non-blocking comments. I didn't notice qnode present anywhere. Is that deliberate?

I'm still working on the new execution flow, see PennyLaneAI/pennylane#6596 . So tests for eval_jaxpr shouldn't care about the larger infrastructure.

AmintorDusko

Nice job! It looks like the failures we have now are essentially linting-related.

tests/lightning_qubit/test_eval_jaxpr.py

albi3ro · 2024-11-28T15:16:21Z

/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")

@AmintorDusko . Jax was installed, so the tests should have run. Ever seen these warnings before?

AmintorDusko · 2024-11-28T15:28:03Z

/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")

@AmintorDusko . Jax was installed, so the tests should have run. Ever seen these warnings before?

Could you please provide a link to the error or the full traceback?

albi3ro · 2024-11-28T15:32:57Z

/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")

@AmintorDusko . Jax was installed, so the tests should have run. Ever seen these warnings before?

Could you please provide a link to the error or the full traceback?

https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/12071248436/job/33662775990

AmintorDusko · 2024-11-28T17:22:17Z

/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/coverage/control.py:892: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")

@AmintorDusko . Jax was installed, so the tests should have run. Ever seen these warnings before?

Could you please provide a link to the error or the full traceback?

https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/12071248436/job/33662775990

Thank you as suggested by @maliasadi, this looks like a pytest split problem.

AmintorDusko

Thank you!

maliasadi

Thanks @albi3ro! 🤩

Don't worry about the codecov warnings! This is not related to your PR and your tests have 💯 coverage. We will fix the issue with CoverageWarning: No data was collected. (no-data-collected) in parallel runs of our pytests as a follow-up.

pennylane_lightning/core/lightning_interpreter.py

tests/lightning_qubit/test_eval_jaxpr.py

…I/pennylane-lightning into lightning-interpreter

mudit2812

Looks good to me

maliasadi

Happy to approve!

albi3ro added 2 commits November 20, 2024 16:35

Implement eval_jaxpr method for lightning.qubit

e34456d

add lightning interpreter

6e95279

albi3ro commented Nov 20, 2024

View reviewed changes

.github/CHANGELOG.md Show resolved Hide resolved

Update .github/CHANGELOG.md

929f618

albi3ro commented Nov 20, 2024

View reviewed changes

pennylane_lightning/lightning_qubit/lightning_interpreter.py Outdated Show resolved Hide resolved

albi3ro and others added 4 commits November 20, 2024 16:56

Update pennylane_lightning/lightning_qubit/lightning_interpreter.py

f9f25cc

docstrings

0a556f3

Auto update version from '0.40.0-dev11' to '0.40.0-dev14'

a498c66

Merge branch 'master' into lightning-interpreter

eb9475c

albi3ro added 2 commits November 21, 2024 13:37

isort and black

1477b94

Merge branch 'lightning-interpreter' of https://github.com/PennyLaneA…

4ffad01

…I/pennylane-lightning into lightning-interpreter

AmintorDusko self-requested a review November 22, 2024 16:18

albi3ro requested a review from mudit2812 November 22, 2024 16:54

mudit2812 reviewed Nov 22, 2024

View reviewed changes

AmintorDusko reviewed Nov 22, 2024

View reviewed changes

albi3ro and others added 5 commits November 27, 2024 17:39

make work with all devices, tidy

8485590

Auto update version from '0.40.0-dev14' to '0.40.0-dev21'

868e4fd

Merge branch 'master' into lightning-interpreter

359f61e

black

42f5846

merging

8134500

AmintorDusko reviewed Nov 28, 2024

View reviewed changes

tests/lightning_qubit/test_eval_jaxpr.py Outdated Show resolved Hide resolved

tests/lightning_qubit/test_eval_jaxpr.py Outdated Show resolved Hide resolved

albi3ro added 3 commits November 28, 2024 09:43

pylint and black

b714456

isort

5d62e3f

more isort

4d9dc88

AmintorDusko reviewed Nov 28, 2024

View reviewed changes

tests/lightning_qubit/test_eval_jaxpr.py Outdated Show resolved Hide resolved

albi3ro and others added 3 commits November 28, 2024 09:56

black again?

6c483be

Update tests/lightning_qubit/test_eval_jaxpr.py

8d9e7da

Auto update version from '0.40.0-dev21' to '0.40.0-dev22'

9fbe2d9

Merge branch 'master' into lightning-interpreter

5973093

Update tests_durations

8c565a0

AmintorDusko approved these changes Nov 28, 2024

View reviewed changes

Add store-durations

83e8721

maliasadi reviewed Nov 28, 2024

View reviewed changes

albi3ro added 3 commits December 2, 2024 15:03

move test file

375dd0b

Merge branch 'lightning-interpreter' of https://github.com/PennyLaneA…

3cb0d5a

…I/pennylane-lightning into lightning-interpreter

Merge branch 'master' into lightning-interpreter

56cf471

albi3ro added ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Dec 2, 2024

Auto update version from '0.40.0-dev23' to '0.40.0-dev24'

f136e78

mudit2812 approved these changes Dec 2, 2024

View reviewed changes

albi3ro requested a review from maliasadi December 2, 2024 22:31

albi3ro and others added 3 commits December 3, 2024 15:20

write additional test

01c5a3f

Auto update version from '0.40.0-dev24' to '0.40.0-dev25'

6fead0c

Merge branch 'master' into lightning-interpreter

360cf5e

maliasadi approved these changes Dec 3, 2024

View reviewed changes

albi3ro merged commit 74ad9a3 into master Dec 3, 2024
93 checks passed

albi3ro deleted the lightning-interpreter branch December 3, 2024 22:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement eval_jaxpr method for lightning.qubit #1002

Implement eval_jaxpr method for lightning.qubit #1002

albi3ro commented Nov 20, 2024 •

edited

Loading

codecov bot commented Nov 21, 2024 •

edited

Loading

mudit2812 left a comment

AmintorDusko left a comment

albi3ro commented Nov 22, 2024

AmintorDusko left a comment

albi3ro commented Nov 28, 2024

AmintorDusko commented Nov 28, 2024 •

edited

Loading

albi3ro commented Nov 28, 2024

AmintorDusko commented Nov 28, 2024

AmintorDusko left a comment

maliasadi left a comment

mudit2812 left a comment

maliasadi left a comment

Implement eval_jaxpr method for lightning.qubit #1002

Implement eval_jaxpr method for lightning.qubit #1002

Conversation

albi3ro commented Nov 20, 2024 • edited Loading

codecov bot commented Nov 21, 2024 • edited Loading

Codecov Report

mudit2812 left a comment

Choose a reason for hiding this comment

AmintorDusko left a comment

Choose a reason for hiding this comment

albi3ro commented Nov 22, 2024

AmintorDusko left a comment

Choose a reason for hiding this comment

albi3ro commented Nov 28, 2024

AmintorDusko commented Nov 28, 2024 • edited Loading

albi3ro commented Nov 28, 2024

AmintorDusko commented Nov 28, 2024

AmintorDusko left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

mudit2812 left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

albi3ro commented Nov 20, 2024 •

edited

Loading

codecov bot commented Nov 21, 2024 •

edited

Loading

AmintorDusko commented Nov 28, 2024 •

edited

Loading