-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding target on device #50
Conversation
Alternative to PennyLaneAI#49 for supporting more targets.
Ready for review! (assuming tests are green here like they are locally :)) |
Thanks @Cynocracy! I've tagged @albi3ro to have a look Edit: the coverage is reduced as the integration test is currently skipped on forked PRs due to security issues. |
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
- Coverage 88.77% 86.66% -2.11%
==========================================
Files 5 5
Lines 285 285
==========================================
- Hits 253 247 -6
- Misses 32 38 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! 💯 The integration tests execute well locally except for 2 tests. The issues are, however, unrelated to the changes in this PR as they seem to fail on master
too.
Overriding the check as the coverage matches the coverage on |
Thank you! |
Alternative to #49 for supporting more targets.