Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding target on device #50

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

Cynocracy
Copy link
Contributor

Alternative to #49 for supporting more targets.

Alternative to PennyLaneAI#49 for supporting more targets.
@Cynocracy
Copy link
Contributor Author

Cynocracy commented Apr 7, 2022

Ready for review! (assuming tests are green here like they are locally :))

@josh146 josh146 requested a review from albi3ro April 7, 2022 21:55
@josh146
Copy link
Member

josh146 commented Apr 7, 2022

Thanks @Cynocracy! I've tagged @albi3ro to have a look

Edit: the coverage is reduced as the integration test is currently skipped on forked PRs due to security issues.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #50 (f92a3db) into master (f69916a) will decrease coverage by 2.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   88.77%   86.66%   -2.11%     
==========================================
  Files           5        5              
  Lines         285      285              
==========================================
- Hits          253      247       -6     
- Misses         32       38       +6     
Impacted Files Coverage Δ
pennylane_ionq/device.py 90.38% <100.00%> (-2.89%) ⬇️
pennylane_ionq/api_client.py 93.08% <0.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f69916a...f92a3db. Read the comment docs.

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 💯 The integration tests execute well locally except for 2 tests. The issues are, however, unrelated to the changes in this PR as they seem to fail on master too.

@antalszava
Copy link
Contributor

Overriding the check as the coverage matches the coverage on master locally.

@antalszava antalszava merged commit ac5f95f into PennyLaneAI:master Apr 13, 2022
@Cynocracy
Copy link
Contributor Author

Thank you!

@Cynocracy Cynocracy deleted the target-arg branch April 13, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants