-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Harmony backend for IonQ #49
Conversation
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
- Coverage 88.77% 85.51% -3.26%
==========================================
Files 5 5
Lines 285 290 +5
==========================================
- Hits 253 248 -5
- Misses 32 42 +10
Continue to review full report at Codecov.
|
Hi @Cynocracy and thanks for opening a PR. Could you provide some information about what you are wanting to achieve with this PR? You may also need to upgrade your version of black and use the |
Thank you! Will update and do another formatting pass |
Also Hi :) Nice to meet you! |
Was something about Does this PR just make it slightly easier to create, fixing something that was broken, or add a new feature? |
That method works fine for now, but we're working on new QPU backend targets, and thought it would map more cleanly into pennylane by adding support here. Are there any reasons to prefer having support in Pennylane itself for different sized QPU backends? If not, I can scrap this PR and keep with the target="" approach |
Tested out that arg, it doesn't seem like we're able to send it through the qml device like you mentioned. I would think that would work for us though, perhaps it's just some missing wiring? |
Alternative to PennyLaneAI#49 for supporting more targets.
Cut #50 as an alternative to this approach |
@Cynocracy let us know when this PR (and also #50) are ready for review :) |
Aye aye! I don't mind closing this in favor of #50 will comment over there when ready for review, am not sure why the tests are failing. |
* Allow overriding target on device Alternative to #49 for supporting more targets. * Fixup tests, add test case
No description provided.