This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Remove EthTaskChainDownloader and supporting code #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelStark
approved these changes
May 1, 2019
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { |
There was a problem hiding this comment.
Optional. Maybe we could test equals and hashCode. Although it is non blocking.
There was a problem hiding this comment.
Equals is only used by tests and hash code isn't used (but should exist to match equals just for good measure). I really only updated them to match our code style which is the generated code.
| return String.format( | ||
| "maxGetBlockHeaders=%s\tmaxGetBlockBodies=%s\tmaxGetReceipts=%s\tmaxGetReceipts=%s", | ||
| maxGetBlockHeaders, maxGetBlockBodies, maxGetReceipts, maxGetNodeData); | ||
| return MoreObjects.toStringHelper(this) |
There was a problem hiding this comment.
toString is always just for debugging purposes so the only time we should test it is when there's sensitive info that definitely shouldn't appear in a log (ie anything containing a password).
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Remove the old EthTaskChainDownloader class and code that is only used by it (plus a few other bits of unused code detected by the static analysis).
We should merge #1372 and #1344 first.