This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Enable the pipeline chain downloader by default #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
approved these changes
Apr 26, 2019
…ce it to use that.
mbaxter
approved these changes
Apr 29, 2019
| @@ -257,7 +258,7 @@ public boolean isActive(final String nodeName) { | |||
| private void killPantheonProcess(final String name, final Process process) { | |||
| LOG.info("Killing " + name + " process"); | |||
|
|
|||
| Awaitility.waitAtMost(30, TimeUnit.SECONDS) | |||
| Awaitility.waitAtMost(60, TimeUnit.SECONDS) | |||
There was a problem hiding this comment.
Did you mean to keep this duration change?
There was a problem hiding this comment.
Yeah it seems to be slower to shutdown in CI than previously. The request open ended headers fix and this increase were needed to get tests passing reliably but I wasn't keen on merging with that many changes after the original approval.
There was a problem hiding this comment.
For the record, shutdown delay was found and fixed in another PR so this duration change wasn't needed.
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The pipeline based downloader is proving to be more stable in low memory conditions and slightly faster than the EthTask based one so switch to the pipeline chain downloader by default for full sync.
Leaving the EthTask based downloader as an option for now but will follow up with a future PR to remove it entirely.