fix: move icon-sprite loading to demo/index.html so that it won't run…

… during unit tests
Pearson-Higher-Ed · Oct 26, 2017 · d7b0c0a · d7b0c0a
1 parent 7701aa8
commit d7b0c0a
Show file tree

Hide file tree

Showing 6 changed files with 270 additions and 517 deletions.
diff --git a/build/images/p-icons-sprite-1.1.svg b/build/images/p-icons-sprite-1.1.svg
diff --git a/demo/index.html b/demo/index.html
@@ -31,6 +31,23 @@
             overflow: auto;
         }
     </style>
+
+    <script>
+    if (!document.getElementById('pe-icons-sprite')) {
+      const pe_ajax=new XMLHttpRequest();
+      pe_ajax.open("GET", "/icons/p-icons-sprite-1.1.svg", true);
+      pe_ajax.responseType="document";
+      pe_ajax.onload=function() {
+        console.log('****  INSERTING ICON SPRITE  ****');
+        console.log(pe_ajax);
+        document.body.insertBefore(
+          pe_ajax.responseXML.documentElement,
+          document.body.childNodes[0]
+        );
+      };
+      pe_ajax.send();
+    }
+    </script>
 </head>
 <body>
     <!-- Customize the demo for your component -->

diff --git a/main.js b/main.js
@@ -137,18 +137,7 @@ export default class CoachMark {
 	}
 
 	init() {
-		if (!document.getElementById('pe-icons-sprite')) {
-			const pe_ajax=new XMLHttpRequest();
-			pe_ajax.open("GET", "/icons/p-icons-sprite-1.1.svg", true);
-			pe_ajax.responseType="document";
-			pe_ajax.onload=function() {
-				document.body.insertBefore(
-					pe_ajax.responseXML.documentElement,
-					document.body.childNodes[0]
-				);
-			};
-			pe_ajax.send();
-		}
+
 
 		ReactDOM.render(
 			<ComponentOwner

diff --git a/npm_scripts/copyStuff.js b/npm_scripts/copyStuff.js
@@ -7,7 +7,7 @@ try {
 }
 
 try {
-  fs.copySync('./node_modules/pearson-elements/assets/icons/p-icons-sprite-1.1.svg', './build/images/p-icons-sprite-1.1.svg')
+  fs.copySync('./node_modules/pearson-elements/assets/icons/p-icons-sprite-1.1.svg', './build/icons/p-icons-sprite-1.1.svg')
 } catch (err) {
   console.error('copy icons error: ' + err)
 }