-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add router for contribution fees #282
Conversation
This pull request has been linked to 2 tasks:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 60.61% 60.96% +0.35%
==========================================
Files 62 63 +1
Lines 2458 2475 +17
Branches 573 573
==========================================
+ Hits 1490 1509 +19
- Misses 772 775 +3
+ Partials 196 191 -5
☔ View full report in Codecov by Sentry. |
Link T-3246 |
We shouldn't use globals here for who can call the claim fees fn. Let's pass an owner on construction and have it be more generic wording. |
For simplicity, we don't actually need to know which type of crowdfund the user is contributing in this contract. It can just be a low level eth call with the given calldata to the given crowdfund. That may be a better approach. |
It's more flexible. Would save us from having to redeploy if we were to add new crowdfund types. And could be adapted to add an optional to any function call, really. I say we go for it. |
837f9eb
to
a070d1b
Compare
2497573
to
d23b88c
Compare
Do we care to be able to switch the owner of the wrapper? I assume its fine like this. |
Since owner is going to be the DAO's multisig, it's unlikely to change. Worse case and it does change, can always deploy a new one with an updated owner and switch over to that. |
* update contribution fee for multiple mints * support NFT crowdfunds * fix test * remove batch contribute nft crowdfund --------- Co-authored-by: Arr00 <[email protected]>
28d6092
to
9b5f379
Compare
* fix: mitigations contributor router * gatekeepers mitigation * initial work on fixing * fix tests * add invalid message value tests * test gatekeeper * fix gatekeep revert * add docs * Update comment contracts/crowdfund/ContributionRouter.sol Co-authored-by: Brian Le <[email protected]> * add delegate note --------- Co-authored-by: Brian Le <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the audit then LGTM!
Implements a crowdfund router that allows contributions to include a flat fee before being passed on to the crowdfund