fix: contributor fee mitigations

[arr00]

No description provided.

[height]

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

[codecov-commenter]

Codecov Report

Patch coverage: 64.00% and project coverage change: +0.01% 🎉

Comparison is base (9b5f379) 60.54% compared to head (f7c5190) 60.55%.

Additional details and impacted files

@@                    Coverage Diff                    @@
##           feat/contribution-fee     #301      +/-   ##
=========================================================
+ Coverage                  60.54%   60.55%   +0.01%     
=========================================================
  Files                         63       63              
  Lines                       2471     2477       +6     
  Branches                     574      574              
=========================================================
+ Hits                        1496     1500       +4     
- Misses                       778      782       +4     
+ Partials                     197      195       -2     

Files Changed	Coverage Δ
contracts/crowdfund/Crowdfund.sol	52.57% <0.00%> (-0.92%)	⬇️
contracts/crowdfund/ETHCrowdfundBase.sol	80.37% <ø> (ø)
contracts/gatekeepers/AllowListGateKeeper.sol	77.77% <0.00%> (-22.23%)	⬇️
contracts/gatekeepers/TokenGateKeeper.sol	88.88% <50.00%> (-11.12%)	⬇️
contracts/crowdfund/ContributionRouter.sol	100.00% <100.00%> (ø)
contracts/crowdfund/InitialETHCrowdfund.sol	86.56% <100.00%> (+4.87%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[0xble]

Some notes, otherwise looks good. It appears to address each of the following:

• Fix excess ETH is lost when maxTotalContributions issue
  • We’re just going to revert when excess ETH is returned (in receiver())
• Fix batchContributeFor calling itself
• Fix gateKeeper checks relying on msg.sender

And looks like we are ignoring the following suggestions, which is fine:

• Add timelock for owner changing feePerMint
• Allow user making contribution to himself through ContributionRouter to set delegate

[0xble]

I don't think it does, but note to self that we'll have to check with FE this doesn't break anything.

[arr00]

good callout. Agree that it's probably fine.