Add OnSaveChanges callback for implementing custom Units of Work
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SzymonPobiega
changed the title
* Run tests on .net core * disabled core build for unit tests until approval tests have core edition * Updated to latest sql transport. * Fixed connection string. * Fixed inspections. * Fixed dtc tests. * Fixed last 2 tests.
SimonCropp
reviewed
Aug 23, 2017
| @@ -20,16 +22,27 @@ public StorageSession(DbConnection connection, DbTransaction transaction, bool o | |||
| internal SagaInfoCache InfoCache { get; } | |||
| public DbTransaction Transaction { get; } | |||
| public DbConnection Connection { get; } | |||
| public void OnSaveChanges(Func<ISqlStorageSession, Task> callback) | |||
There was a problem hiding this comment.
should also nullcheck callback
|
minor feedback. but rest looks good |
SzymonPobiega
force-pushed
the
onsavedchanges
branch
from
c97cbb3 to
079ab7a
Compare
SzymonPobiega
changed the title
SzymonPobiega
added a commit
that referenced
this pull request
Aug 24, 2017
SzymonPobiega
changed the title
OnSaveChanges callback for implementing custom Units of Work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after
tests-on-core