Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: 'EntityFramework integration' #3108

Closed
SimonCropp opened this issue Aug 23, 2017 · 6 comments
Closed

Feedback: 'EntityFramework integration' #3108

SimonCropp opened this issue Aug 23, 2017 · 6 comments
Assignees

Comments

@SimonCropp
Copy link
Contributor

SimonCropp commented Aug 23, 2017

Feedback for 'EntityFramework integration' https://docs.particular.net/samples/entity-framework/

Location in GitHub: https://github.com/Particular/docs.particular.net/blob/master/samples/entity-framework/sample.md

ping @Particular/nhibernate-persistence-maintainers

Should this be moved to use the sql persistence?

@SzymonPobiega
Copy link
Member

Yeah. And probably it should be called "EF Unit of Work sample" because the EF integration (without the UoW support) is already covered in SQL persistence data access sample.

@SzymonPobiega SzymonPobiega self-assigned this Aug 23, 2017
@SzymonPobiega
Copy link
Member

Ooops. I've just noticed that there is no OnSaveChanges method in SQL persistence so I can't build the unit of work just yet.

@DavidBoike
Copy link
Member

Does the merge of Particular/NServiceBus.Persistence.Sql#156 unblock this?

@SzymonPobiega
Copy link
Member

@DavidBoike Yeah. So the plan would be to delete the existing sample and add a new one based on SQL persistence (V3 only). Is that OK?

@DavidBoike
Copy link
Member

👍

@weralabaj
Copy link
Contributor

Addressed in #3465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants