Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded interchange SIGTERM handler #3635

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Remove unneeded interchange SIGTERM handler #3635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0855766
Remove unneeded interchange SIGTERM handler
benclifford Oct 10, 2024
a61ecb0
Merge branch 'master' into benc-interchange-sigterm
benclifford Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions parsl/executors/high_throughput/interchange.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import pickle
import platform
import queue
import signal
import sys
import threading
import time
Expand Down Expand Up @@ -313,16 +312,6 @@ def start(self) -> None:
""" Start the interchange
"""

# If a user workflow has set its own signal handler for sigterm, that
# handler will be inherited by the interchange process because it is
# launched as a multiprocessing fork process.
# That can interfere with the interchange shutdown mechanism, which is
# to receive a SIGTERM and exit immediately.
# See Parsl issue #2343 (Threads and multiprocessing cannot be
# intermingled without deadlocks) which talks about other fork-related
# parent-process-inheritance problems.
signal.signal(signal.SIGTERM, signal.SIG_DFL)

logger.info("Starting main interchange method")

if self.hub_address is not None and self.hub_zmq_port is not None:
Expand Down
Loading