Remove unneeded interchange SIGTERM handler #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in PR #2629 to guard against the submit process installing a SIGTERM handler and then that handler being unexpectedly inherited by the interchange via multiprocesssing fork PR #3463 changed the interchange to run as a fresh Python process, which will not inherit SIGTERM handlers, so since then this line has been vestigial. Fixes issue #3588
rjmello
approved these changes
Oct 14, 2024
benclifford
added a commit
that referenced
this pull request
Oct 22, 2024
Prioer to PR #3463, the interchange process was launched with multiprocessing fork and inherited the log configuration of the parent process. To give the interchange its own log file, a specific logger, called "interchange" was used. In PR #2307, this logger was configured to not propagate entries upwards, so that user defined root handlers in the parent process do not see interchange logs. Since #3463 this special configuration has no longer been necessary. See #3635 for a related change to signal handlers.
benclifford
added a commit
that referenced
this pull request
Oct 24, 2024
Prior to PR #3463, the interchange process was launched with multiprocessing fork and inherited the log configuration of the parent process. To give the interchange its own log file, a specific logger, called "interchange" was used. In PR #2307, this logger was configured to not propagate entries upwards, so that user defined root handlers in the parent process do not see interchange logs. Since #3463 this special configuration has no longer been necessary. See #3635 for a related change to signal handlers. Co-authored-by: Kevin Hunter Kesling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in PR #2629 to guard against the submit process installing a SIGTERM handler and then that handler being unexpectedly inherited by the interchange via multiprocesssing fork
PR #3463 changed the interchange to run as a fresh Python process, which will not inherit SIGTERM handlers, so since then this line has been vestigial.
Fixes issue #3588
Changed Behaviour
none - the interchange should already be starting with the default signal handler for SIGTERM
Type of change