Improve cancelling PreCreatureSpawnEvent with per player mob spawns #9400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, for this fast fix. I hope this gets merged soon. |
kennytv
reviewed
Jun 27, 2023
This comment was marked as spam.
This comment was marked as spam.
Machine-Maker
force-pushed
the
fix/PreCreatureSpawnEvent-per-player-mob-spawns
branch
from
42efe70 to
1b22d9a
Compare
|
Any updates on this? Isn't it fine to merge already? |
|
Please do not let this die in pull request queue. |
kennytv
approved these changes
Jul 8, 2023
|
Fixes also #5076 |
|
Can you provide a snapshot build with this patch and without the test plugin to run a smoother server until this gets merged? @Machine-Maker |
Machine-Maker
added
the
build-pr-jar
|
That was fast! Will the action to build the paperclip.jar get started automatically? |
Huh, it should've automatically started when I added the label. |
Machine-Maker
added
build-pr-jar
Machine-Maker
force-pushed
the
fix/PreCreatureSpawnEvent-per-player-mob-spawns
branch
from
1b22d9a to
c15bf12
Compare
Machine-Maker
force-pushed
the
fix/PreCreatureSpawnEvent-per-player-mob-spawns
branch
from
c15bf12 to
135c45f
Compare
kennytv
force-pushed
the
fix/PreCreatureSpawnEvent-per-player-mob-spawns
branch
from
135c45f to
37d7fd7
Compare
Machine-Maker
deleted the
fix/PreCreatureSpawnEvent-per-player-mob-spawns
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implementation of #5460
Fixes #9393
Tracks an additional count of mobs per category for each category. The number is incremented on an aborted or cancelled PreCreatureSpawnEvent. That number is added to the true mob count per player when the game requests the mob count for a player. This "backoff number" is then decremented by 1 each tick for each player for each mob category.
A rudimentary test I did involved a plain server with 1 player not moving for 60 seconds. With the PreCreatureSpawnEvent set to be cancelled and aborted WITHOUT these changes, it fired ~48000 times during that time period. With the changes, it fired ~5000 times over the same time period. I included the test plugin I used to do this in the PR. Will be removed before merging.
The algorithm used to decrease the "backoff number" is linear and simple now, unclear if it should be customizable further, or default to a non-linear implementation.
Download the paperclip jar for this pull request: paper-9400.zip