Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#347 - Adding protocol to EmailServer class #348

Merged
merged 4 commits into from
Jun 7, 2021
Merged

#347 - Adding protocol to EmailServer class #348

merged 4 commits into from
Jun 7, 2021

Conversation

ntwrkguru
Copy link
Contributor

@ntwrkguru ntwrkguru commented Jun 7, 2021 •
edited
Loading

Signed-off-by: Stephen Steiner [email protected]

Description

Adding protocol attribute to the EmailServer class in panos.device to support the changes in PanOS 10+

Motivation and Context

Since the introduction of PanOS 10, the email server configuration requires the protocol attribute as either SMTP or TLS

How Has This Been Tested?

Ran poetry run make test
Ran poetry run make test-all (Failed, but for other than changes made)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@welcome-to-palo-alto-networks
Copy link

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@ntwrkguru ntwrkguru changed the title #347 - Adding protocol to EmailServer class [WIP] #347 - Adding protocol to EmailServer class Jun 7, 2021
@ntwrkguru ntwrkguru changed the title [WIP] #347 - Adding protocol to EmailServer class #347 - Adding protocol to EmailServer class Jun 7, 2021
@ntwrkguru
Copy link
Contributor Author

Fixes #347

@ntwrkguru ntwrkguru mentioned this pull request Jun 7, 2021
Closed
ntwrkguru added 2 commits June 7, 2021 14:25
@ntwrkguru
348 fixed parameters
0f8a965 
Signed-off-by: Stephen Steiner <[email protected]>
@ntwrkguru
348 formatting
3e51a6c 
Signed-off-by: Stephen Steiner <[email protected]>
shinmog
shinmog approved these changes Jun 7, 2021
View reviewed changes
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shinmog shinmog merged commit e28b359 into PaloAltoNetworks:develop Jun 7, 2021
@welcome-to-palo-alto-networks
Copy link

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

github-actions bot pushed a commit that referenced this pull request Jun 24, 2021
@semantic-release-bot
chore(release): 1.3.0
da6aebf 
## [1.3.0](v1.2.0...v1.3.0) (2021-06-24)

### Features

* Add logsettings system and config ([#340](#340)) ([fe90ab7](fe90ab7))
* Add protocol to EmailServer class ([#348](#348)) ([e28b359](e28b359)), closes [#347](#347)

### Bug Fixes

* Add new email server params ([0272f2d](0272f2d))
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinmog shinmog shinmog approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntwrkguru @shinmog