Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PANOS 10 EMAIL PROTOCOL ATTRIBUTE MISSING #347

Closed
ntwrkguru opened this issue Jun 7, 2021 · 2 comments
Closed

PANOS 10 EMAIL PROTOCOL ATTRIBUTE MISSING #347

ntwrkguru opened this issue Jun 7, 2021 · 2 comments
Labels
bug released

Comments

@ntwrkguru
Copy link
Contributor

Describe the bug

Startting in PANOS 10, the email server configuration requires a protocol to be provided. pan-os-python does not support this attribute and causes an error on commit.

Validation Error: | log-settings -> email -> default -> server -> default is missing 'protocol' | log-settings -> email -> default -> server is invalid

Expected behavior

All required attributes are supported via parameters

Current behavior

It is not currently possible to provide the protocol parameter

Possible solution

Add protocol parameter to class EmailServer

Steps to reproduce

Discovered in Ansible

Your Environment

Ansible 2.11.1
paloaltonetworks.panos 2.6.0 collection
Python 3.9.5
pan-os-python 1.2.0
pan-python 0.16.0
MacOS 10.15.7
@ntwrkguru ntwrkguru added the bug label Jun 7, 2021
@welcome-to-palo-alto-networks
Copy link

🎉 Thanks for opening your first issue here! Welcome to the community!

ntwrkguru added a commit to ntwrkguru/pan-os-python that referenced this issue Jun 7, 2021
@ntwrkguru
PaloAltoNetworks#347 - Adding protocol to EmailServer class
e15f884 
Signed-off-by: Stephen Steiner <[email protected]>
ntwrkguru added a commit to ntwrkguru/pan-os-python that referenced this issue Jun 7, 2021
@ntwrkguru
PaloAltoNetworks#347 - Added defaults to device.EmailServer protocol …
3a4a339 
…parameter

Signed-off-by: Stephen Steiner <[email protected]>
@ntwrkguru ntwrkguru mentioned this issue Jun 7, 2021
Merged
4 tasks
@shinmog shinmog closed this as completed in e28b359 Jun 7, 2021
github-actions bot pushed a commit that referenced this issue Jun 24, 2021
@semantic-release-bot
chore(release): 1.3.0
da6aebf 
## [1.3.0](v1.2.0...v1.3.0) (2021-06-24)

### Features

* Add logsettings system and config ([#340](#340)) ([fe90ab7](fe90ab7))
* Add protocol to EmailServer class ([#348](#348)) ([e28b359](e28b359)), closes [#347](#347)

### Bug Fixes

* Add new email server params ([0272f2d](0272f2d))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ntwrkguru