-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
230 missing protocol email server #231
Merged
mrichardson03
merged 51 commits into
PaloAltoNetworks:develop
from
ntwrkguru:230-missing-protocol-email-server
Jun 14, 2021
Merged
230 missing protocol email server #231
mrichardson03
merged 51 commits into
PaloAltoNetworks:develop
from
ntwrkguru:230-missing-protocol-email-server
Jun 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
ntwrkguru
changed the title
[WIP] 230 missing protocol email server
230 missing protocol email server
Jun 14, 2021
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
* Use ansible-core instead of ansible * Don't allow pre-release packages (include black specifically) * Recreate Pipfile.lock from scratch * test: Ansible 2.11 sanity fixes
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
mrichardson03
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 20, 2021
## [2.7.0](v2.6.0...v2.7.0) (2021-07-20) ### Features * **panos_email_server:** Add protocol ([#231](#231)) ([b4a0b1a](b4a0b1a)) * **panos_import:** Support import to template ([#225](#225)) ([82db7fe](82db7fe)) * **panos_security_rule:** Add audit comment ([#229](#229)) ([bae2483](bae2483)), closes [#228](#228) * **panos_tag_object:** Add new colors ([#111](#111)) ([#234](#234)) ([1703f29](1703f29)) * Add httpapi connection ([#223](#223)) ([5d11cfc](5d11cfc)) * Add panos_config_element ([be878d4](be878d4)), closes [#219](#219) ### Bug Fixes * **panos_facts:** Fix IPv6 on subinterfaces ([#218](#218)) ([51e1f55](51e1f55))
🎉 This PR is included in version 2.7.0 🎉 The release is available on Ansible Galaxy and GitHub release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the protocol attribute to panos_email_server.py
Motivation and Context
PanOS 10+ requires the protocol to be set for email server configuration
How Has This Been Tested?
TBD
Screenshots (if appropriate)
Types of changes
Checklist