Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

230 missing protocol email server #231

Conversation

ntwrkguru
Copy link
Contributor

@ntwrkguru ntwrkguru commented Jun 7, 2021

Description

Adds support for the protocol attribute to panos_email_server.py

Motivation and Context

PanOS 10+ requires the protocol to be set for email server configuration

How Has This Been Tested?

TBD

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

ntwrkguru added 16 commits June 2, 2021 09:26
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
@ntwrkguru ntwrkguru changed the title [WIP] 230 missing protocol email server 230 missing protocol email server Jun 14, 2021
dependabot bot and others added 22 commits June 14, 2021 10:28
* Use ansible-core instead of ansible
* Don't allow pre-release packages (include black specifically)
* Recreate Pipfile.lock from scratch
* test: Ansible 2.11 sanity fixes
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Copy link
Contributor

@mrichardson03 mrichardson03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@mrichardson03 mrichardson03 merged commit b4a0b1a into PaloAltoNetworks:develop Jun 14, 2021
@welcome-to-palo-alto-networks

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

github-actions bot pushed a commit that referenced this pull request Jul 20, 2021
## [2.7.0](v2.6.0...v2.7.0) (2021-07-20)

### Features

* **panos_email_server:** Add protocol ([#231](#231)) ([b4a0b1a](b4a0b1a))
* **panos_import:** Support import to template ([#225](#225)) ([82db7fe](82db7fe))
* **panos_security_rule:** Add audit comment ([#229](#229)) ([bae2483](bae2483)), closes [#228](#228)
* **panos_tag_object:** Add new colors ([#111](#111)) ([#234](#234)) ([1703f29](1703f29))
* Add httpapi connection ([#223](#223)) ([5d11cfc](5d11cfc))
* Add panos_config_element ([be878d4](be878d4)), closes [#219](#219)

### Bug Fixes

* **panos_facts:** Fix IPv6 on subinterfaces ([#218](#218)) ([51e1f55](51e1f55))
@github-actions
Copy link

🎉 This PR is included in version 2.7.0 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants