230 missing protocol email server

Makefile

@@ -18,7 +18,7 @@ else ifneq (ansible_collections,$(toplevel))
 endif
 
 python_version := $(shell \
-  python -c 'import sys; print(".".join(map(str, sys.version_info[:2])))' \
+  python3 -c 'import sys; print(".".join(map(str, sys.version_info[:2])))' \
 )
 
 

galaxy.yml

@@ -9,7 +9,7 @@ namespace: 'paloaltonetworks'
 name: 'panos'
 
 # The version of the collection. Must be compatible with semantic versioning
-version: 2.6.0
+version: '2.6.0'
 
 # The path to the Markdown (.md) readme file. This path is relative to the root of the collection
 readme: 'README.md'

plugins/modules/panos_email_server.py

@@ -69,6 +69,14 @@
         description:
             - IP address or FQDN of email gateway to use.
         type: str
+    protocol:
+        description:
+            - Specify whether to use clear-text or encrypted SMTP.
+        type: str
+        choices:
+            - SMTP
+            - TLS
+        default: SMTP
 """
 
 EXAMPLES = """
@@ -119,6 +127,7 @@ def main():
             to_email=dict(),
             also_to_email=dict(),
             email_gateway=dict(),
+            protocol=dict(choices=["SMTP", "TLS"], default="SMTP"),
         ),
     )
     module = AnsibleModule(
@@ -146,6 +155,7 @@ def main():
         "to": module.params["to_email"],
         "also_to": module.params["also_to_email"],
         "email_gateway": module.params["email_gateway"],
+        "protocol": module.params["protocol"],
     }
     obj = EmailServer(**spec)
     sp.add(obj)

tests/integration/firewall/test_panos_security_rule.yml

@@ -13,6 +13,7 @@
     application: ['ssh']
     action: 'allow'
     device_group: '{{ device_group | default(omit) }}'
+    audit_comment: 'Test audit comment'
   register: result
 
 - name: test_panos_security_rule - Assert create was successful
@@ -33,6 +34,7 @@
     application: ['ssh']
     action: 'allow'
     device_group: '{{ device_group | default(omit) }}'
+    audit_comment: 'Testing audit_comment'
   register: result
 
 - name: test_panos_security_rule - Assert create (idempotence) was successful