228 add rule audit comment #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
…into 228-add-rule-audit-comment
mrichardson03
suggested changes
Jun 14, 2021
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
Signed-off-by: Stephen Steiner <[email protected]>
…-os-ansible into 228-add-rule-audit-comment
Signed-off-by: Stephen Steiner <[email protected]>
mrichardson03
approved these changes
Jun 14, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jul 20, 2021
## [2.7.0](v2.6.0...v2.7.0) (2021-07-20) ### Features * **panos_email_server:** Add protocol ([#231](#231)) ([b4a0b1a](b4a0b1a)) * **panos_import:** Support import to template ([#225](#225)) ([82db7fe](82db7fe)) * **panos_security_rule:** Add audit comment ([#229](#229)) ([bae2483](bae2483)), closes [#228](#228) * **panos_tag_object:** Add new colors ([#111](#111)) ([#234](#234)) ([1703f29](1703f29)) * Add httpapi connection ([#223](#223)) ([5d11cfc](5d11cfc)) * Add panos_config_element ([be878d4](be878d4)), closes [#219](#219) ### Bug Fixes * **panos_facts:** Fix IPv6 on subinterfaces ([#218](#218)) ([51e1f55](51e1f55))
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on Ansible Galaxy and GitHub release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to provide an audit comment with a rule creation
Motivation and Context
Brings feature parity with a new feature added to the underlying pan-os-python lib
How Has This Been Tested?
Local test playbook
Types of changes
Checklist
Playbook run passes, but
sanitytest throws a lot of module errors that don't seem to be related to changes I've made. Full output is here. Any help is appreciated!PS. Please squash my ugly commit history on merge. :-)