-
-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix formatting before commit #1779
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@LakshyaSatpal Please fix the failing tests. |
You may need to merge with the latest upstream. |
My branch up to date with develop. The error in tests is unrelated to my changes. |
Please restore the ts-node dependency in this PR. |
I see I don't think we need to run |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1779 +/- ##
===========================================
- Coverage 98.17% 98.14% -0.04%
===========================================
Files 184 226 +42
Lines 10767 13685 +2918
Branches 835 1144 +309
===========================================
+ Hits 10571 13431 +2860
- Misses 186 222 +36
- Partials 10 32 +22 ☔ View full report in Codecov by Sentry. |
@palisadoes Tests are passing now. |
|
|
Merging. Something isn't right |
2c2e70a
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
This PR adds a pre-commit script run, to fix formatting
Issue Number:
Fixes #1778
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?