-
-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add formatting pre-commit check #1778
Comments
Closing. This doesn't seem valid |
|
if we want to format all code before committing, issue remains open. Else, we can close this. (In talawa-admin, pre-commit formats full code https://github.com/PalisadoesFoundation/talawa-admin/blob/main/.husky/pre-commit ) PS: The issue was raised because I'd to fix the formatting and re-push my changes in my other PR #1774, maybe I was not on the latest code, and that's why the GitHub PR workflow format check was failing. |
OK, that makes sense. |
Is your feature request related to a problem? Please describe.
We don't check correct prettier formatting of code before commit, though we do have lint checks.
Describe the solution you'd like
Use the scripts defined in package.json and check for formatting before every commit.
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359
The text was updated successfully, but these errors were encountered: