-
-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded react, react-dom, tests/react and react-toastify to latest #2205
Upgraded react, react-dom, tests/react and react-toastify to latest #2205
Conversation
Lowercase primitives for consistency. Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 149 files out of 255 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2205 +/- ##
===========================================
- Coverage 97.55% 97.31% -0.24%
===========================================
Files 244 244
Lines 6939 6953 +14
Branches 2000 2020 +20
===========================================
- Hits 6769 6766 -3
- Misses 155 173 +18
+ Partials 15 14 -1 ☔ View full report in Codecov by Sentry. |
Closing this PR since it is too big and includes unnecessary changes. |
Issue Number:
Fixes #2057
Fixes #1950
Did you add tests for your changes?
Yes
Summary
A high level overview of the changes:
ReactDOM.render
tocreateRoot
import { act } from react
instead of the depreciated testing libraryDefault.props
because it shows a warning in React 18 since it will be removed in a future major release of React.Does this PR introduce a breaking change?
Not really
Have you read the contributing guide?
Yes