Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package react, react-dom and @types/react #2057

Closed
palisadoes opened this issue Jun 24, 2024 · 14 comments
Closed

Upgrade package react, react-dom and @types/react #2057

palisadoes opened this issue Jun 24, 2024 · 14 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers no-issue-activity No issue activity security Security fix test Testing application

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade react, [react-dom](https://github.com/facebook/react/
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs

Release Note Details

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps react, react-dom and @types/react. These dependencies needed to be updated together.
Updates react from 17.0.2 to 18.3.1

Release notes

Sourced from react's releases.

18.3.1 (April 26, 2024)

  • Export act from react f1338f

18.3.0 (April 25, 2024)

This release is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19.

Read the React 19 Upgrade Guide for more info.

React

  • Allow writing to this.refs to support string ref codemod 909071
  • Warn for deprecated findDOMNode outside StrictMode c3b283
  • Warn for deprecated test-utils methods d4ea75
  • Warn for deprecated Legacy Context outside StrictMode 415ee0
  • Warn for deprecated string refs outside StrictMode #25383
  • Warn for deprecated defaultProps for function components #25699
  • Warn when spreading key #25697
  • Warn when using act from test-utils d4ea75

React DOM

  • Warn for deprecated unmountComponentAtNode 8a015b
  • Warn for deprecated renderToStaticNodeStream #28874

18.2.0 (June 14, 2022)

React DOM

React DOM Server

  • Pass information about server errors to the client. (@​salazarm and @​gnoff in #24551 and #24591)
  • Allow to provide a reason when aborting the HTML stream. (@​gnoff in #24680)
  • Eliminate extraneous text separators in the HTML where possible. (@​gnoff in #24630)
  • Disallow complex children inside <title> elements to match the browser constraints. (@​gnoff in #24679)
  • Fix buffering in some worker environments by explicitly setting highWaterMark to 0. (@​jplhomer in #24641)

Server Components (Experimental)

18.1.0 (April 26, 2022)

React DOM

... (truncated)

Changelog

Sourced from react's changelog.

18.3.1 (April 26, 2024)

  • Export act from react f1338f

18.3.0 (April 25, 2024)

This release is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19.

Read the React 19 Upgrade Guide for more info.

React

  • Allow writing to this.refs to support string ref codemod 909071
  • Warn for deprecated findDOMNode outside StrictMode c3b283
  • Warn for deprecated test-utils methods d4ea75
  • Warn for deprecated Legacy Context outside StrictMode 415ee0
  • Warn for deprecated string refs outside StrictMode #25383
  • Warn for deprecated defaultProps for function components #25699
  • Warn when spreading key #25697
  • Warn when using act from test-utils d4ea75

React DOM

  • Warn for deprecated unmountComponentAtNode 8a015b
  • Warn for deprecated renderToStaticNodeStream #28874

18.2.0 (June 14, 2022)

React DOM

React DOM Server

  • Pass information about server errors to the client. (@​salazarm and @​gnoff in #24551 and #24591)
  • Allow to provide a reason when aborting the HTML stream. (@​gnoff in #24680)
  • Eliminate extraneous text separators in the HTML where possible. (@​gnoff in #24630)
  • Disallow complex children inside <title> elements to match the browser constraints. (@​gnoff in #24679)
  • Fix buffering in some worker environments by explicitly setting highWaterMark to 0. (@​jplhomer in #24641)

Server Components (Experimental)

18.1.0 (April 26, 2022)

React DOM

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by react-bot, a new releaser for react since your current version.


Updates react-dom from 17.0.2 to 18.3.1

Release notes

Sourced from react-dom's releases.

18.3.1 (April 26, 2024)

  • Export act from react f1338f

18.3.0 (April 25, 2024)

This release is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19.

Read the React 19 Upgrade Guide for more info.

React

  • Allow writing to this.refs to support string ref codemod 909071
  • Warn for deprecated findDOMNode outside StrictMode c3b283
  • Warn for deprecated test-utils methods d4ea75
  • Warn for deprecated Legacy Context outside StrictMode 415ee0
  • Warn for deprecated string refs outside StrictMode #25383
  • Warn for deprecated defaultProps for function components #25699
  • Warn when spreading key #25697
  • Warn when using act from test-utils d4ea75

React DOM

  • Warn for deprecated unmountComponentAtNode 8a015b
  • Warn for deprecated renderToStaticNodeStream #28874

18.2.0 (June 14, 2022)

React DOM

React DOM Server

  • Pass information about server errors to the client. (@​salazarm and @​gnoff in #24551 and #24591)
  • Allow to provide a reason when aborting the HTML stream. (@​gnoff in #24680)
  • Eliminate extraneous text separators in the HTML where possible. (@​gnoff in #24630)
  • Disallow complex children inside <title> elements to match the browser constraints. (@​gnoff in #24679)
  • Fix buffering in some worker environments by explicitly setting highWaterMark to 0. (@​jplhomer in #24641)

Server Components (Experimental)

18.1.0 (April 26, 2022)

React DOM

... (truncated)

Changelog

Sourced from react-dom's changelog.

18.3.1 (April 26, 2024)

  • Export act from react f1338f

18.3.0 (April 25, 2024)

This release is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19.

Read the React 19 Upgrade Guide for more info.

React

  • Allow writing to this.refs to support string ref codemod 909071
  • Warn for deprecated findDOMNode outside StrictMode c3b283
  • Warn for deprecated test-utils methods d4ea75
  • Warn for deprecated Legacy Context outside StrictMode 415ee0
  • Warn for deprecated string refs outside StrictMode #25383
  • Warn for deprecated defaultProps for function components #25699
  • Warn when spreading key #25697
  • Warn when using act from test-utils d4ea75

React DOM

  • Warn for deprecated unmountComponentAtNode 8a015b
  • Warn for deprecated renderToStaticNodeStream #28874

18.2.0 (June 14, 2022)

React DOM

React DOM Server

  • Pass information about server errors to the client. (@​salazarm and @​gnoff in #24551 and #24591)
  • Allow to provide a reason when aborting the HTML stream. (@​gnoff in #24680)
  • Eliminate extraneous text separators in the HTML where possible. (@​gnoff in #24630)
  • Disallow complex children inside <title> elements to match the browser constraints. (@​gnoff in #24679)
  • Fix buffering in some worker environments by explicitly setting highWaterMark to 0. (@​jplhomer in #24641)

Server Components (Experimental)

18.1.0 (April 26, 2022)

React DOM

... (truncated)

Commits
  • d6c42f7 Bump to 18.3.1
  • 8a015b6 Add deprecation warning for unmountComponentAtNode
  • c3b2839 Add deprecation warning for findDOMNode
  • d4ea75d ReactDOMTestUtils deprecation warnings
  • 7548c01 Deprecate renderToStaticNodeStream (#28872) (#28874)
  • 5894232 Enable warning for defaultProps on function components for everyone (#25699)
  • c2a246e Turn on string ref deprecation warning for everybody (not codemoddable) (#25383)
  • 2cfb474 Bump version from 18.2 to 18.3
  • b345523 [Fizz] Support abort reasons (#24680)
  • bcbeb52 [Fizz] Disallow complex children in <title> elements (#24679)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by react-bot, a new releaser for react-dom since your current version.


Updates @types/react from 17.0.62 to 18.3.3

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@palisadoes palisadoes added bug Something isn't working good first issue Good for newcomers security Security fix dependencies Pull requests that update a dependency file labels Jun 24, 2024
@github-actions github-actions bot added test Testing application unapproved labels Jun 24, 2024
Copy link

github-actions bot commented Jul 5, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jul 5, 2024
@swapnil-SN7
Copy link

please , can you assign it to me

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jul 6, 2024
@AradhyaDixit18
Copy link

can you assign this to me as i have upgraded this projects want to make a pull request.

@swapnil-SN7 swapnil-SN7 removed their assignment Jul 15, 2024
@govindsingh3477
Copy link
Contributor

can you please assign this to me . I have previously worked with React and frontend and node .

@varshith257
Copy link
Member

varshith257 commented Jul 17, 2024

@govindsingh3477 As @AradhyaDixit18 stated that already worked on upgrading. Let's give.him a chance as order for request to assign.

@govindsingh3477 I think there are many open good first issues. Have a look at them. If you interested any to work on them tag me

@govindsingh3477
Copy link
Contributor

@varshith257 No problem @varshith257

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jul 28, 2024
@palisadoes
Copy link
Contributor Author

Unassigning. Inactive

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jul 31, 2024
@Aaradhy-Sharma
Copy link
Contributor

Hello!
Please assign this issue to me, I'd love to give it a try!
Regards

@adithyanotfound
Copy link
Contributor

I'm currently working on issue #1950 which require me to upgrade react and react-dom. Please assign this issue to me.

@Cioppolo14
Copy link
Contributor

We typically assign these items to the first person who commented, but in this case we asked @adithyanotfound to complete this task but didn't assign the corresponding issue. I will assign. Please keep looking for good issues to complete, we appreciate your help, @Aaradhy-Sharma.

@adithyanotfound
Copy link
Contributor

Screenshot 2024-08-09 at 3 02 29 PM

The droppable method from 'react-beautiful-dnd' shows this error message in React18 during tests. Is there any specific alternative you want me to use or am I free to choose?

@palisadoes
Copy link
Contributor Author

Please use your initiative and select a suitable option.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers no-issue-activity No issue activity security Security fix test Testing application
Projects
Archived in project
Development

No branches or pull requests

8 participants