Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tensorrt output varible reshape #31733

Merged
merged 7 commits into from
Mar 23, 2021

Conversation

shangzhizhou
Copy link
Member

@shangzhizhou shangzhizhou commented Mar 19, 2021

PR types

Bug fixes

PR changes

Others

Describe

fix bug of PR #29308
remove ernie fc padded shape

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

cryoco
cryoco previously approved these changes Mar 19, 2021
Copy link
Contributor

@cryoco cryoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cryoco
cryoco previously approved these changes Mar 22, 2021
Comment on lines 145 to 150
PADDLE_ENFORCE_EQ(
x_num_col_dims == 1 || x_num_col_dims == 2, true,
platform::errors::InvalidArgument(
"Wrong x_num_col_dims param of op mul. Paddle-TRT FC converter "
"expects x_num_col_dims is either 1 or 2, but got %d",
x_num_col_dims));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个要不要拿到opteller里

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

cryoco
cryoco previously approved these changes Mar 23, 2021
Copy link
Contributor

@cryoco cryoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shangzhizhou shangzhizhou merged commit 9d04ef7 into PaddlePaddle:develop Mar 23, 2021
@shangzhizhou shangzhizhou deleted the fix_fc_1 branch March 24, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants