Fix missing mavlink includes #869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinDeric
commented
Jun 5, 2022
| @@ -24,6 +24,8 @@ | |||
| #include <boost/algorithm/string.hpp> | |||
| #include <opencv2/opencv.hpp> | |||
|
|
|||
| // Mavlink includes | |||
| #include <ardupilotmega/ardupilotmega.h> | |||
There was a problem hiding this comment.
This PR is only a 2-liner update. i'll rebase on master showing this after #868 is merged
Similar update in src/gazebo_gimbal_controller_plugin.cpp file below.
Jaeyoung-Lim
requested changes
Jun 6, 2022
| @@ -24,6 +24,8 @@ | |||
| #include <boost/algorithm/string.hpp> | |||
| #include <opencv2/opencv.hpp> | |||
|
|
|||
| // Mavlink includes | |||
| #include <ardupilotmega/ardupilotmega.h> | |||
There was a problem hiding this comment.
We should not be using the ardupilot mega dialect, since this contains specific mavlink messages for the ardupilot project. PX4 is not compatible with the ardupilot project
There was a problem hiding this comment.
Agree, however this is where i found the types when building mavlink. here are the steps to reproduce: https://github.com/PX4/PX4-SITL_gazebo/pull/868/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R30. Where are these types located for you and how did you generate them? A standard method thats documented would be very helpful.
> [ 9/10] RUN source "/opt/ros/galactic/setup.bash" && export CPLUS_INCLUDE_PATH=/mavlink/include/mavlink/v2.0 && colcon build:
#13 1.042 Starting >>> mavlink_sitl_gazebo
#13 124.3 --- stderr: mavlink_sitl_gazebo
#13 124.3 CMake Warning:
#13 124.3 Manually-specified variables were not used by the project:
#13 124.3
#13 124.3 CATKIN_INSTALL_INTO_PREFIX_ROOT
#13 124.3
#13 124.3
#13 124.3 /ros_ws/src/mavlink_sitl_gazebo/src/gazebo_gimbal_controller_plugin.cpp: In member function ‘void gazebo::GimbalControllerPlugin::HandleCommandLong(const mavlink_message_t&)’:
#13 124.3 /ros_ws/src/mavlink_sitl_gazebo/src/gazebo_gimbal_controller_plugin.cpp:805:10: error: ‘MAV_CMD_REQUEST_MESSAGE’ was not declared in this scope
#13 124.3 805 | case MAV_CMD_REQUEST_MESSAGE:
#13 124.3 | ^~~~~~~~~~~~~~~~~~~~~~~
#13 124.3 /ros_ws/src/mavlink_sitl_gazebo/src/gazebo_gimbal_controller_plugin.cpp:808:10: error: ‘MAV_CMD_SET_MESSAGE_INTERVAL’ was not declared in this scope; did you mean ‘MAVLINK_MSG_ID_MESSAGE_INTERVAL’?
#13 124.3 808 | case MAV_CMD_SET_MESSAGE_INTERVAL:
#13 124.3 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#13 124.3 | MAVLINK_MSG_ID_MESSAGE_INTERVAL
#13 124.3 make[2]: *** [CMakeFiles/gazebo_gimbal_controller_plugin.dir/build.make:63: CMakeFiles/gazebo_gimbal_controller_plugin.dir/src/gazebo_gimbal_controller_plugin.cpp.o] Error 1
#13 124.3 make[1]: *** [CMakeFiles/Makefile2:1026: CMakeFiles/gazebo_gimbal_controller_plugin.dir/all] Error 2
#13 124.3 make[1]: *** Waiting for unfinished jobs....
#13 124.3 /ros_ws/src/mavlink_sitl_gazebo/src/gazebo_camera_manager_plugin.cpp: In member function ‘void gazebo::CameraManagerPlugin::_handle_message(mavlink_message_t*, sockaddr*)’:
#13 124.3 /ros_ws/src/mavlink_sitl_gazebo/src/gazebo_camera_manager_plugin.cpp:310:18: error: ‘MAV_CMD_IMAGE_START_CAPTURE’ was not declared in this scope
#13 124.3 310 | case MAV_CMD_IMAGE_START_CAPTURE:
#13 124.3 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
#13 124.3 /ros_ws/src/mavlink_sitl_gazebo/src/gazebo_camera_manager_plugin.cpp:313:18: error: ‘MAV_CMD_IMAGE_STOP_CAPTURE’ was not declared in this scope
#13 124.3 313 | case MAV_CMD_IMAGE_STOP_CAPTURE:
#13 124.3 | ^~~~~~~~~~~~~~~~~~~~~~~~~~
#13 124.3 /ros_ws/src/mavlink_sitl_gazebo/src/gazebo_camera_manager_plugin.cpp:316:18: error: ‘MAV_CMD_REQUEST_CAMERA_INFORMATION’ was not declared in this scope; did you mean ‘MAVLINK_MSG_ID_CAMERA_INFORMATION’?
#13 124.3 316 | case MAV_CMD_REQUEST_CAMERA_INFORMATION:
#13 124.3 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#13 124.3 | MAVLINK_MSG_ID_CAMERA_INFORMATION
#13 124.3 /ros_ws/src/mavlink_sitl_gazebo/src/gazebo_camera_manager_plugin.cpp:319:18: error: ‘MAV_CMD_REQUEST_CAMERA_CAPTURE_STATUS’ was not declared in this scope; did you mean ‘MAVLINK_MSG_ID_CAMERA_CAPTURE_STATUS’?
#13 124.3 319 | case MAV_CMD_REQUEST_CAMERA_CAPTURE_STATUS:
#13 124.3 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#13 124.3 | MAVLINK_MSG_ID_CAMERA_CAPTURE_STATUS
#13 124.3 /ros_ws/src/mavlink_sitl_gazebo/src/gazebo_camera_manager_plugin.cpp:322:18: error: ‘MAV_CMD_REQUEST_STORAGE_INFORMATION’ was not declared in this scope; did you mean ‘MAVLINK_MSG_ID_STORAGE_INFORMATION’?
#13 124.3 322 | case MAV_CMD_REQUEST_STORAGE_INFORMATION:
#13 124.3 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#13 124.3 | MAVLINK_MSG_ID_STORAGE_INFORMATION
#13 124.3 /ros_ws/src/mavlink_sitl_gazebo/src/gazebo_camera_manager_plugin.cpp:325:18: error: ‘MAV_CMD_REQUEST_CAMERA_SETTINGS’ was not declared in this scope
#13 124.3 325 | case MAV_CMD_REQUEST_CAMERA_SETTINGS:
#13 124.3 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
There was a problem hiding this comment.
@AustinDeric Since the common setup is that this repo is used as a submodule of the PX4-Autopilot project, it uses the header generated there. Otherwise if you want to use this repository as a standalone catkin project, you can use the catkin mavlink package: https://github.com/mavlink/mavlink-gbp-release
|
@AustinDeric Raised problem in mavlink/mavros#1767 |
|
Fixed in Fixed in #896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds missing mavlink includes which resolves the missing mavlink types:
All these are found in the file generated by mavlink, located at:
mavlink_root_filder/include/mavlink/v2.0/ardupilotmega/ardupilotmega.hThe bug is reproduced here: #868
This build is shown successful here (and this PR when CI is turned on): AustinDeric#1