-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ROS build CI #868
Closed
Closed
Fix ROS build CI #868
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3236491
reproduce bug https://github.com/PX4/PX4-SITL_gazebo/runs/6721857960
AustinDeric 9b6cdbd
integrate mavlink in CI
AustinDeric 2853535
fix nested submodule errors https://github.com/PX4/PX4-SITL_gazebo/ru…
AustinDeric 69908e4
fix nested submodules failing https://github.com/PX4/PX4-SITL_gazebo/…
AustinDeric File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.git/ | ||
.github/ | ||
Dockerfile |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
name: ROS Build Test | ||
on: | ||
push: | ||
branches: | ||
- master | ||
pull_request: | ||
branches: | ||
- '*' | ||
|
||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
config: | ||
- {rosdistro: 'melodic'} | ||
- {rosdistro: 'noetic'} | ||
- {rosdistro: 'galactic'} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: submodule update | ||
run: git submodule update --init --recursive | ||
- | ||
name: Build and push | ||
uses: docker/build-push-action@v3 | ||
with: | ||
context: . | ||
build-args: | | ||
ROS_DISTRO=${{matrix.config.rosdistro}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
# This Dockerfile is for CI purposes only | ||
# To build this image from the root repo path: | ||
# docker build . | ||
ARG ROS_DISTRO=galactic | ||
FROM ros:${ROS_DISTRO} | ||
|
||
SHELL ["/bin/bash", "-c"] | ||
|
||
RUN apt-get update && apt-get install -y \ | ||
python3-colcon-common-extensions \ | ||
python3-pip \ | ||
git \ | ||
&& rm -rf /var/lib/apt/lists/* | ||
|
||
COPY package.xml /ros_ws/src/mavlink_sitl_gazebo/package.xml | ||
|
||
WORKDIR /ros_ws/ | ||
|
||
RUN apt-get update && \ | ||
rosdep update && \ | ||
rosdep install --from-paths src --ignore-src -y --rosdistro ${ROS_DISTRO} \ | ||
&& rm -rf /var/lib/apt/lists/* | ||
|
||
WORKDIR / | ||
|
||
# Install mavlink | ||
RUN git clone --recursive --depth=1 https://github.com/mavlink/mavlink.git && \ | ||
cd mavlink && \ | ||
pip3 install future jinja2 && \ | ||
python3 -m pymavlink.tools.mavgen --lang=C++11 --wire-protocol=2.0 \ | ||
--output=/mavlink/include/mavlink/v2.0 message_definitions/v1.0/all.xml | ||
|
||
WORKDIR /ros_ws/ | ||
|
||
COPY . /ros_ws/src/mavlink_sitl_gazebo | ||
|
||
RUN source "/opt/ros/${ROS_DISTRO}/setup.bash" && \ | ||
export CPLUS_INCLUDE_PATH=/mavlink/include/mavlink/v2.0 && \ | ||
colcon build | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very familiar with colcon, but this is build testing ROS1 versions with colcon, which was not the intention of the catkin build tests. Could you elaborate on what we would gain switching to colcon and whether it would verify also building with catkin?