Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISTANCE_SENSOR adopting #2200

Closed
wants to merge 61 commits into from
Closed

DISTANCE_SENSOR adopting #2200

wants to merge 61 commits into from

Conversation

TSC21
Copy link
Member

@TSC21 TSC21 commented May 19, 2015

[work in progress] This PR pretends to add DISTANCE_SENSOR msg as the main message for pub range sensor data, being altimeters or side sensors for obsavoid.

Zefz and others added 13 commits March 24, 2015 10:04
LorenzMeier
LorenzMeier reviewed May 20, 2015
View reviewed changes
src/modules/uORB/topics/distance_sensor.h
*/
struct distance_sensor_s {

uint32_t time_boot_ms; /**< Time since system boot */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this into the msg folder and let it auto-generate.

@TSC21
Copy link
Member Author

TSC21 commented May 20, 2015

@LorenzMeier can you please do a mavlink release so I can add msg.type = MAV_DISTANCE_SENSOR_INFRARED to mavlink/mavlink_messages.cpp? Thanks

@mhkabir
Copy link
Member

mhkabir commented May 20, 2015

@TSC21 Can you please remove the auto-generated uorb topic file. :)

@TSC21
Copy link
Member Author

TSC21 commented May 20, 2015

Remove? Lorenz asked me in a comment to add it :D

@vooon
Copy link
Contributor

vooon commented May 20, 2015

@TSC21 @mhkabir mean remove .h-file, now it generates from .msg-file.

@TSC21
Copy link
Member Author

TSC21 commented May 20, 2015

OK I understood now. I was comparing the .h in the repo vs the ones generated and checked that the autogenerated ones are not in the repo. Thanks for warning me ;)

This was referenced May 20, 2015
Merged
Merged
Closed
@LorenzMeier
Copy link
Member

I updated the mavlink lib on master.

@TSC21 TSC21 mentioned this pull request May 21, 2015
Closed
@TSC21
Copy link
Member Author

TSC21 commented May 21, 2015

@LorenzMeier thanks!

bansiesta and others added 14 commits May 24, 2015 10:01
@bansiesta
ringbuffer: whitespace
b9ce447
@bansiesta
ringbuffer: use a namespace for ringbuffer to avoid 'multiple definit…
aac2768 
…ions in vtable' bug
@bansiesta
drivers: use new ringbuffer namespace everywhere
21dfd02
@bansiesta
drivers: various whitespace
362fc20
@bansiesta
Merge branch 'fix_ringbuffer' into lidarlite_merge
d473b8b
@bansiesta
uORB: added pwm_input to objects_common
7cec6d3
@TSC21
Merge branch 'master' of https://github.com/PX4/Firmware into distanc…
5672df8 
…e_sensor
@bansiesta
ll40ls: Weffc++ was complaining about 'class LidarLitePWM' has pointe…
1151996 
…r data members, had to disable it
@bansiesta
pwm_input: comment style
4e897bf
@bansiesta
pwm_input: get rid of start full and instead start whenever someone r…
bb3ad64 
…eads from the driver, as well as various other small changes
@bansiesta
ll40ls: adapt the cli interface, so that the commands work with the P…
0ab0de5 
…WM and I2C driver
@bansiesta
ll40ls: removed unneeded comments
fbc4ca6
@bansiesta
ll40ls: changed I2C driver to new ringbuffer namespace, and various s…
ef658cf 
…tyle stuff
@bansiesta
ll40ls: made PWM driver version functional
e7f1f3b
@bansiesta bansiesta mentioned this pull request May 24, 2015
Merged
bansiesta and others added 11 commits May 24, 2015 13:00
@TSC21
Copy link
Member Author

TSC21 commented May 24, 2015

I'm closing this PR, as #2224 is the current one!

@TSC21 TSC21 closed this May 24, 2015
@bansiesta
Copy link
Contributor

@Zefz and @TSC21: thanks for the work here. I made a bunch of changes, mostly to the LidarLitePWM, and finally got the PWM driver running in #2224 which is now merged.

@TSC21 TSC21 deleted the distance_sensor branch May 26, 2015 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TSC21 @mhkabir @vooon @LorenzMeier @bansiesta @jgoppert @Zefz