Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: summon results filtering fix #72

Merged
merged 4 commits into from
Jul 12, 2024
Merged

fix: summon results filtering fix #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1db96b
fix: summon results filtering fix
AlexanderBlanchardAC Jun 12, 2024
46d3975
fix: adjust code for facets to allow them to be unchecked
AlexanderBlanchardAC Jun 10, 2024
4b53fd8
Merge branch '24.07.00' of https://github.com/mdnoble73/aspen-discove…
AlexanderBlanchardAC Jul 12, 2024
2128d2f
chore: Update change log
AlexanderBlanchardAC Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions code/web/release_notes/24.07.00.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@

### Summon Updates
- Adjustments to code in Summon getFacetSet function to correct a bug. Individual facet filters can now be unchecked and the filter unset by clicking the checkbox. (*AB*)
- Adjust code to ensure that the filter applies correctly no matter what page of results users are on when they apply it. (*AB*)

### Other Updates
- Show the original translation term when translating text within Aspen. (*MDN*)
Expand Down
2 changes: 1 addition & 1 deletion code/web/sys/SearchObject/SummonSearcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ public function getFacetSet() {
if ($isApplied) {
$facetSettings['removalUrl'] = $this->renderLinkWithoutFilter($facetId . ':' . $facetValue);
} else {
$facetSettings['url'] = $this->renderSearchUrl() . '&filter[]=' . $facetId . ':' . urlencode($facetValue);
$facetSettings['url'] = $this->renderSearchUrl() . '&filter[]=' . $facetId . ':' . urlencode($facetValue) . '&page=1';
}
$list[] = $facetSettings;
}
Expand Down