Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: summon results filtering fix #72

Conversation

AlexanderBlanchardAC
Copy link

Adjust code so that if not on page one of results when a filter is applied, the new results set begins on page one.
Fix bug: if current result numerical value is greater than the number of results available in a facet filter, the facet filter did not apply when clicked.

TEST PLAN:
Prior to applying patch:

  1. Carry out a search in Summon.
  2. Move to a results page that is greater than page 1.
  3. Apply a facet.
  4. Notice that when results load, they start form the page and result number you were on prior to selecting a filter.

APPLY PATCH

  1. Repeat the above.
  2. Notice that this time when the page reloads after selecting a facet filter, you are on page one of your new results set.

Adjust code so that if not on page one of results when a filter is applied,
the new results set begins on page one.
Fix bug: if current result numerical value is greater than the number of
results available in a facet filter, the facet filter did not apply
when clicked.
@Jacobomara901
Copy link

Jacobomara901 commented Jun 28, 2024

This seems to break the facet uncheck for me mate.
To replicate:
apply patch
check facet filter
takes you back to page one as expected
unchecking the filter now does nothing
clicking the stop sign above for the facet will still remove it

Adjust code to allow Summon facet filters to be unchecked if they are clicked why $isApplied
is true
@AlexanderBlanchardAC
Copy link
Author

This seems to break the facet uncheck for me mate. To replicate: apply patch check facet filter takes you back to page one as expected unchecking the filter now does nothing clicking the stop sign above for the facet will still remove it

I have cherry picked the commit that fixed the unchecking so it should work now :).

@Chloe070196
Copy link

Patch seems to work fine - just need to update the changelog before it can be approved

@AlexanderBlanchardAC AlexanderBlanchardAC changed the base branch from summon_facet_results to fix_summon_facet_results July 12, 2024 12:02
@Chloe070196 Chloe070196 merged commit 8262dc3 into PTFS-Europe:fix_summon_facet_results Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants