Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete simtax.py and SimpleTaxIO class and associated tests #2142

Merged
merged 3 commits into from
Dec 4, 2018
Merged

Remove obsolete simtax.py and SimpleTaxIO class and associated tests #2142

merged 3 commits into from
Dec 4, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Nov 30, 2018

The SimpleTaxIO class and the simtax.py program that used that class were first developed to support taxcalc/validation activities. Then the ideas behind simtax.py evolved into the tc command-line interface to Tax-Calculator using the more general TaxCalcIO class. Pull request #2140 changes validation logic so that it uses tc instead of simtax.py. These changes make simtax.py, and the SimpleTaxIO class it calls, obsolete. As a result, this pull request removes simtax.py, the SimpleTaxIO class, and associated tests.

@codecov-io
Copy link

codecov-io commented Nov 30, 2018

Codecov Report

Merging #2142 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2142      +/-   ##
=========================================
- Coverage   99.91%   99.9%   -0.01%     
=========================================
  Files          16      15       -1     
  Lines        3520    3240     -280     
=========================================
- Hits         3517    3237     -280     
  Misses          3       3
Impacted Files Coverage Δ
taxcalc/__init__.py 100% <ø> (ø) ⬆️
taxcalc/taxcalcio.py 99.52% <100%> (ø) ⬆️
taxcalc/calculator.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e43717...40bba4c. Read the comment docs.

@martinholmer martinholmer removed the ready label Dec 4, 2018
@martinholmer martinholmer merged commit 1ada60e into PSLmodels:master Dec 4, 2018
@martinholmer martinholmer deleted the remove-simtax branch December 4, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants