Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logic in taxcalc/validation/taxsim/ so it works with new TAXSIM-27 #2140

Merged
merged 22 commits into from
Dec 4, 2018
Merged

Change logic in taxcalc/validation/taxsim/ so it works with new TAXSIM-27 #2140

merged 22 commits into from
Dec 4, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Nov 30, 2018

This pull request revises the old validation logic, which worked with TAXSIM 9, so that it now works with Internet TAXSIM version 27.

Note that the minimum required version of pandas has been increased from 0.22 to 0.23 because the new validation test logic relies on this new argument-order-preservation feature when the DataFrame constructor is passed a dictionary as data:

screen shot 2018-12-03 at 3 40 39 pm

@codecov-io
Copy link

codecov-io commented Nov 30, 2018

Codecov Report

Merging #2140 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
- Coverage   99.91%   99.91%   -0.01%     
==========================================
  Files          16       16              
  Lines        3520     3519       -1     
==========================================
- Hits         3517     3516       -1     
  Misses          3        3
Impacted Files Coverage Δ
taxcalc/decorators.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e43717...db481e8. Read the comment docs.

@martinholmer martinholmer removed the ready label Dec 4, 2018
@martinholmer martinholmer merged commit f36f02b into PSLmodels:master Dec 4, 2018
@martinholmer martinholmer deleted the update-validation branch December 4, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants